-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization of kdtrees for PFBlockAlgo and optimize track-hcal links #31295
Merged
cmsbuild
merged 15 commits into
cms-sw:master
from
hatakeyamak:KDTreeTracckHcalEcalLinkOptimization
Sep 15, 2020
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c4abf6a
Re-organize the track-hcal and track-ecal kdtrees. Allow specifying t…
hatakeyamak c9d6755
cleanup
hatakeyamak 38cf211
Add minAbsEtaEcal for controlling the eta range for ECAL-HCAL links
hatakeyamak 1f8dc5b
Introduce a const minPFRecHitFrac for controlling the min rechit frac…
hatakeyamak 84ca2c5
Exclude the requirement of the max hcal links per track from displace…
hatakeyamak 3aceffa
PR31295 for HLT configs.
hatakeyamak ba64a58
Merge branch 'master' into KDTreeTracckHcalEcalLinkOptimization
hatakeyamak d73ec72
Add nMaxHcalLinksPerTrack to Phase2 track-HFEM and track-HFHAD linking.
hatakeyamak d1c31ee
Clean up for-loops and track selection.
hatakeyamak 1bb9d90
Cleanup.
hatakeyamak b088835
Modify PF multilinks_ in order to store link information for differen…
hatakeyamak cae8675
Do not apply the max hfhad link per track cut for now.
hatakeyamak 4b345ca
Update PFMultilinksTC.h
hatakeyamak 3aa9a95
Further improve the use of multilinks for prefilters in linkers.
hatakeyamak fe86258
Merge branch 'KDTreeTracckHcalEcalLinkOptimization' of https://github…
hatakeyamak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this fragment will be called in production to update the linker parameters with the right values. I wonder if there is a more robust way of propagating the pfblock configuration updates to HLT, as here we are overriding the types, and also relying quite heavily on the particular PSet structure.
I think also the function name could perhaps be made a bit more descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a normal convention to use this format, but I added a more description to this python file.