New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing include in FWCore/Framework / dependencies and MagneticField/Engine #31300
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31300/18030
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/Framework @perrotta, @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
I'm a bit curious to learn how modules build lead up to finding out these includes were missing. I mean, does it check missing includes also outside of the packages generating dictionaries, or is there a dependency chain from such package to |
Its more sensitive to capturing things that you directly use via #include and via BuildFiles as if a module is not yet built and no dependency (at the include level rather than just .so level) is declared the built fails. Of course often the low level package is built first due to some indirect dependency or via a race condition (just as with .so dependencies), so things tend to come one by one.
(I’m not sure why my build reported a missing #include of cassert today, but it did..)
On Aug 31, 2020, at 3:28 PM, Matti Kortelainen <notifications@github.com<mailto:notifications@github.com>> wrote:
I'm a bit curious to learn how modules build lead up to finding out these includes were missing. I mean, does it check missing includes also outside of the packages generating dictionaries, or is there a dependency chain from such package to FWCore/Framework? Or something else?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31300 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5NTIYKLBKFC3LPPJLSDOQQBANCNFSM4QQOAEQA>.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Missing items found in modules build.