Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: TrackerGeometryBuilder Track FilteredView info #31307

Merged
merged 2 commits into from Sep 2, 2020

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Aug 31, 2020

PR description:

Progress on #31143, please see: #31143 (comment)

PR validation:

$ cmsRun SimG4Core/Configuration/test/ddd_ZMM_Run3_Step1_cfg.py
$ cmsRun SimG4Core/Configuration/test/ddd_ZMM_Run3_Step2_cfg.py
$ cmsRun SimG4Core/Configuration/test/dd4hep_ZMM_Run3_Step3_cfg.py # Still breaking but producing better logs

@ianna dd4hep::FilteredView::nextSibling() and dd::FilteredView::nextSibling() are taking us to different nodes. Is that the expected behavior?

Include copynumber, << is defined for geoHistory and DDExpandedNode
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31307/18050

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vargasa (Andres Vargas) for master.

It involves the following packages:

Geometry/TrackerNumberingBuilder
SimG4Core/Configuration

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @JanFSchulte, @rovere, @VinInn, @ebrondol, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

@vargasa This PR looks like a draft or test PR. What are your plans for it? Do you want the PR tests run?

@vargasa
Copy link
Contributor Author

vargasa commented Aug 31, 2020

Hi @cvuosalo, yes please. The plan is to have it merged

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7c0a15a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2355b/9029/summary.html
CMSSW: CMSSW_11_2_X_2020-08-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2355b/9029/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609638
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 1, 2020

+1

@civanch
Copy link
Contributor

civanch commented Sep 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link
Contributor

ianna commented Sep 2, 2020

@ianna dd4hep::FilteredView::nextSibling() and dd::FilteredView::nextSibling() are taking us to different nodes. Is that the expected behavior?

yes

@silviodonato silviodonato changed the title DD4hep: TrackerGeometryBuilder Track FV info DD4hep: TrackerGeometryBuilder Track FilteredView info Sep 2, 2020
@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants