New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD4hep: TrackerGeometryBuilder Track FilteredView info #31307
Conversation
Include copynumber, << is defined for geoHistory and DDExpandedNode
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31307/18050
|
A new Pull Request was created by @vargasa (Andres Vargas) for master. It involves the following packages: Geometry/TrackerNumberingBuilder @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@vargasa This PR looks like a draft or test PR. What are your plans for it? Do you want the PR tests run? |
Hi @cvuosalo, yes please. The plan is to have it merged |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
yes |
+1 |
PR description:
Progress on #31143, please see: #31143 (comment)
PR validation:
@ianna
dd4hep::FilteredView::nextSibling()
anddd::FilteredView::nextSibling()
are taking us to different nodes. Is that the expected behavior?