Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small enhancements to geometry DB payload validation scripts #31320

Merged
merged 12 commits into from Sep 5, 2020

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Sep 1, 2020

runDDDvsDBGeometryValidation.sh compares new geometry DB payloads with the geometry XML files and the payloads in the Conditions DB. It will show differences down to the level of |1.e-23|. This PR adds the option to reduce the precision of comparison to |1.e-7| to allow focusing on big differences without being overwhelmed with tiny numerical fluctuations.
Also, values in simulation geometry that are shown to four decimal places are rounded to zero if they are < |5.e-5| to avoid showing differences between 0.0000 and -0.0000, which are not very helpful.

These scripts are for expert use and have no effect on production workflows.

No backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31320/18077

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

DetectorDescription/OfflineDBLoader
Geometry/CSCGeometry
Geometry/DTGeometry
Geometry/TrackerGeometryBuilder
Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@battibass, @makortel, @vargasa, @JanFSchulte, @rovere, @VinInn, @venturia, @apsallid, @lecriste, @ptcox, @ebrondol, @rishabhCMS, @mtosi, @fabiocos, @slomeo, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 1, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+1
Tested at: 293e40b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51560a/9050/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31320/18150

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

Pull request #31320 was updated. @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please check and sign again.

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 4, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

+1
Tested at: e742e3d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51560a/9118/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51560a/9118/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ianna
Copy link
Contributor

ianna commented Sep 4, 2020

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b767de into cms-sw:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants