Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CUDA host code if CUDA libraries are available #31334

Merged
merged 4 commits into from Sep 4, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 2, 2020

PR description:

Relax the condition for building CUDA host code to check only for the availability of the CUDA libraries, without requiring the possibility to compile CUDA device code.
This makes them available - for example - in GCC 10 builds.

PR validation:

The affected packages now build with GCC 10, and the CUDAService can be loaded:

$ echo $SCRAM_ARCH 
slc7_amd64_gcc820

$ cmsRun HeterogeneousCore/CUDAServices/test/testCUDAService.py 
%MSG-w CUDAService:  (NoModuleName) 02-Sep-2020 16:25:51 CEST pre-events
Failed to initialize the CUDA runtime.
Disabling the CUDAService.
%MSG

Relax the condition for building CUDA utilities and services to check
only the availability of the CUDA libraries, without requiring the
possibility to compile CUDA device code.

This makes them available - for example - in GCC 10 builds.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The code-checks are being triggered in jenkins.

Relax the condition for building CUDA utilities and services to check
only the availability of the CUDA libraries, without requiring the
possibility to compile CUDA device code.

This makes them available - for example - in GCC 10 builds.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31334/18094

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDAServices
HeterogeneousCore/CUDAUtilities

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The code-checks are being triggered in jenkins.

@fwyzard fwyzard changed the title Build CUDA utilities if CUDA libraries are available Build CUDA host code if CUDA libraries are available Sep 2, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2020

@cmsbuild, please test

@makortel
Copy link
Contributor

makortel commented Sep 3, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

+1
Tested at: 829da5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7212c9/9093/summary.html
CMSSW: CMSSW_11_2_X_2020-09-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7212c9/9093/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Sep 4, 2020

+1

  • Technical, it does its job: it adds protection when cuda libraries are not available
  • Jenkins tests pass both in "standard" architectures and witg gcc10

@silviodonato
Copy link
Contributor

I'm going to merge this in the next IB. Any objections @cms-sw/alca-l2 ?

@christopheralanwest
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4ca30cc into cms-sw:master Sep 4, 2020
@fwyzard fwyzard deleted the Update_CUDA_dependencies branch December 27, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants