New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CUDA host code if CUDA libraries are available #31334
Conversation
Relax the condition for building CUDA utilities and services to check only the availability of the CUDA libraries, without requiring the possibility to compile CUDA device code. This makes them available - for example - in GCC 10 builds.
The code-checks are being triggered in jenkins. |
Relax the condition for building CUDA utilities and services to check only the availability of the CUDA libraries, without requiring the possibility to compile CUDA device code. This makes them available - for example - in GCC 10 builds.
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31334/18094
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: HeterogeneousCore/CUDAServices @makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
I'm going to merge this in the next IB. Any objections @cms-sw/alca-l2 ? |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Relax the condition for building CUDA host code to check only for the availability of the CUDA libraries, without requiring the possibility to compile CUDA device code.
This makes them available - for example - in GCC 10 builds.
PR validation:
The affected packages now build with GCC 10, and the
CUDAService
can be loaded: