/validation/RecoEgamma/ # bins and ranges histos modifications.

[archiron]

PR description:

The range and binning of a few histograms have been made configurable so that they can be adjusted for the Phase2 validation through an Era modifier.

Modifications are made in plugins folder (ElectronMcSignalValidatior.cc/h and ElectronMcFakeValidator.cc/h) and into the python folder (ElectronMcSignalValidator_gedGsfElectrons_cfi.py, ElectronMcSignalValidatorPt1000_gedGsfElectrons_cfi.py, ElectronMcFakeValidator_gedGsfElectrons_cfi.py).
hard coded values have been replaced with named values which can be modified into python files, and the values are adjusted for PHASE2 validation via an era modifier.

links :
before modifications : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU2/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/
after modifications : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU4/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/

special tests :
before : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU2/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/gifs/h_recOfflineVertices.gif
after : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU4/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/gifs/h_recOfflineVertices.gif

before : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU2/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/gifs/h_scl_EoEtrueVsrecOfflineVertices_barrel_pfx.gif
after : http://cms-egamma.web.cern.ch/cms-egamma/validation/Electrons/Dev/TEST_FOLDER/GedvsGed_TEST_FOLDER_PU4/Fullgedvsged_RelValZEE_14_gedGsfE_Startup/gifs/h_scl_EoEtrueVsrecOfflineVertices_barrel_pfx.gif

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (34 33 32 24 16 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch -> OK.
• verify that changes follow CMS Naming, Coding, And Style Rules -> OK.
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions -> OK.

@beaudett

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31348/18125

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31348/18125/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31348/18125/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31348/18128

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

Validation/RecoEgamma

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9090/console Started: 2020/09/03 14:05

[cmsbuild]

+1
Tested at: 6119627
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf10a2/9090/summary.html
CMSSW: CMSSW_11_2_X_2020-09-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf10a2/9090/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 151
• DQMHistoTests: Total successes: 2609483
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1794.014 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 44.930 KiB EgammaV/ElectronMcSignalValidator
• DQMHistoSizes: changed ( 10024.0,... ): 44.930 KiB EgammaV/ElectronMcSignalValidatorPt1000
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 23234.0,... ): 73.828 KiB EgammaV/ElectronMcSignalValidator
• DQMHistoSizes: changed ( 23234.0,... ): 73.828 KiB EgammaV/ElectronMcSignalValidatorPt1000
• DQMHistoSizes: changed ( 23234.0,... ): 1.055 KiB EgammaV/ElectronMcFakeValidator
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

HI @archiron
I believe the changes you described are in line with what we get in the WF validation, but it would be nice if you can confirm:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-09-02-2300+bf10a2/38624/dqm-histo-comparison-summary.html
Thanks

[archiron]

Sorry, but what do you say with "WF validation". It is the fisrt time I read that.
is it the name for CMS DQM GUI ?
Arnaud

@beaudett

[jfernan2]

WF = Workflow Flow
I was asking mainly for a confirmation if the changes we get in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-09-02-2300+bf10a2/38624/dqm-histo-comparison-summary.html
are what you expect
Thanks

[archiron]

It seems all is OK. Sorry for the delay, I looked over all histograms and all is as we expect.
thanks.
Arnaud

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1