to make static analyzer happy in RunningAverage #31352

slava77 · 2020-09-03T15:04:17Z

SA reported a dead assignment

this seems more like a false positive.
I think that this update should remove the issue at no cost in performance

cmsbuild · 2020-09-03T15:04:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-03T15:09:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31352/18135

This PR adds an extra 16KB to repository

cmsbuild · 2020-09-03T15:09:54Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2020-09-03T15:12:22Z

@cmsbuild, please test

cmsbuild · 2020-09-03T15:12:44Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-03-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9099/console Started: 2020/09/03 17:15

cmsbuild · 2020-09-03T17:18:33Z

+1
Tested at: 9f9c081
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9099/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Small fixes for tauReco at miniAOD #31330 @cms-tau-pog: Small fixes for tauReco at miniAOD
Break circular dependency between DataFormats/TrackReco and DataFormats/TrackCandidate #31327 @davidlange6: Break circular dependency between DataFormats/TrackReco and DataFormats/TrackCandidate
GE21 fix nstrips for 16 eta partition option #31225 @watson-ij: GE21 fix nstrips for 16 eta partition option
SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273 @davidlange6: SimDataFormats/ValidationFormats - move G4 dependency out of data format

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9099/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9099/git-merge-result

cmsbuild · 2020-09-03T17:18:35Z

Comparison job queued.

cmsbuild · 2020-09-03T18:48:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9099/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-09-03T18:57:32Z

FWCore/Utilities/interface/RunningAverage.h

@@ -29,7 +29,8 @@ namespace edm {

    int upper() const {
      auto lm = mean();
-      return lm += (std::abs(m_buffer[0] - lm) + std::abs(m_buffer[N / 2] - lm));
+      lm += (std::abs(m_buffer[0] - lm) + std::abs(m_buffer[N / 2] - lm));
+      return lm;


I suppose

return lm + (std::abs(m_buffer[0] - lm) + std::abs(m_buffer[N / 2] - lm));

would work as well.

you are right.

makortel · 2020-09-03T18:57:40Z

+1

cmsbuild · 2020-09-03T18:58:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-09-03T19:04:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-03T19:09:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31352/18143

This PR adds an extra 16KB to repository

cmsbuild · 2020-09-03T19:09:24Z

Pull request #31352 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

makortel · 2020-09-03T19:10:04Z

@cmsbuild, please test

cmsbuild · 2020-09-03T19:10:28Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-03-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9110/console Started: 2020/09/03 21:12

cmsbuild · 2020-09-03T21:19:51Z

+1
Tested at: a11e5bf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9110/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Small fixes for tauReco at miniAOD #31330 @cms-tau-pog: Small fixes for tauReco at miniAOD
Break circular dependency between DataFormats/TrackReco and DataFormats/TrackCandidate #31327 @davidlange6: Break circular dependency between DataFormats/TrackReco and DataFormats/TrackCandidate
GE21 fix nstrips for 16 eta partition option #31225 @watson-ij: GE21 fix nstrips for 16 eta partition option
SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273 @davidlange6: SimDataFormats/ValidationFormats - move G4 dependency out of data format

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9110/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9110/git-merge-result

cmsbuild · 2020-09-03T21:19:54Z

Comparison job queued.

cmsbuild · 2020-09-03T22:47:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e53462/9110/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-09-03T22:56:07Z

+1

Thanks for the update

cmsbuild · 2020-09-03T22:56:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-04T02:28:08Z

+1

to make static analyzer happy in RunningAverage

9f9c081

cmsbuild added this to the CMSSW_11_2_X milestone Sep 3, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Sep 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 3, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 3, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 3, 2020

makortel reviewed Sep 3, 2020

View reviewed changes

cmsbuild added core-approved and removed core-pending pending-signatures labels Sep 3, 2020

cmsbuild added comparison-pending core-pending pending-signatures tests-pending labels Sep 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 3, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 3, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 3, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 4, 2020

cmsbuild merged commit c2db05f into cms-sw:master Sep 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

to make static analyzer happy in RunningAverage #31352

to make static analyzer happy in RunningAverage #31352

slava77 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 •

edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel Sep 3, 2020

slava77 Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 •

edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

qliphy commented Sep 4, 2020

to make static analyzer happy in RunningAverage #31352

to make static analyzer happy in RunningAverage #31352

Conversation

slava77 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 • edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel Sep 3, 2020

Choose a reason for hiding this comment

slava77 Sep 3, 2020

Choose a reason for hiding this comment

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 • edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

qliphy commented Sep 4, 2020

cmsbuild commented Sep 3, 2020 •

edited

cmsbuild commented Sep 3, 2020 •

edited