Biased tau decayer update #31353
Merged
Biased tau decayer update #31353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code-checks are being triggered in jenkins. |
|
@intrepid42 @mkirsano This should address the changes for Pythia8.30X. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31353/18136
|
|
A new Pull Request was created by @smrenna (Stephen Mrenna) for master. It involves the following packages: GeneratorInterface/Pythia8Interface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@cms-sw/generators-l2 any comments? |
agrohsje
reviewed
Sep 8, 2020
| Settings* settingsPtr, | ||
| ParticleData* particleDataPtr, | ||
| Rndm* rndmPtr) { | ||
| BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) { |
There was a problem hiding this comment.
Hi @smrenna . I seems to overlook something. Where do we propagate Settings* settingsPtr to P8, or differently asked, what happens to this argument in BiasedTauDecayer ?
|
I will have to double check later, but I think that CMS is using the Pythia Settings class
to set some options.
Steve
From: agrohsje <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Tuesday, September 8, 2020 at 12:24 PM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Biased tau decayer update (#31353)
@agrohsje commented on this pull request.
________________________________
In GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23discussion-5Fr484915101&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=CtRe2Sebm46t9RG-HQ7APeVquHxl03QXskN6W2YuhGk&e=>:
@@ -8,11 +8,9 @@ using namespace Pythia8;
// leptonic decays
//
…-BiasedTauDecayer::BiasedTauDecayer(const Info* infoPtr,
- Settings* settingsPtr,
- ParticleData* particleDataPtr,
- Rndm* rndmPtr) {
+BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) {
Hi @smrenna<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_smrenna&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=flwDcdfCG85i0nzE3-fpZ52--PYwHlgCWEL5PAtYHoY&e=> . I seems to overlook something. Where do we propagate Settings* settingsPtr to P8, or differently asked, what happens to this argument in BiasedTauDecayer ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23pullrequestreview-2D484136101&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=4StSiFu0mDm8tOHj-xL6op3uS0uNhCd39UFfeKYKLMA&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJEXEBXVNKVIMBESTNTSEZSFNANCNFSM4QU4VZJA&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=vog73PUS4zH6n_uATqWWBB90ErXSewqt9peBvsJRNeQ&e=>.
|
|
filter_ = settingsPtr->flag("BiasedTauDecayer:filter");
eDecays_ = settingsPtr->flag("BiasedTauDecayer:eDecays");
muDecays_ = settingsPtr->flag("BiasedTauDecayer:muDecays");
(this is inside the {} of the BiasedTauDecayer.)
From: agrohsje <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Tuesday, September 8, 2020 at 12:24 PM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Biased tau decayer update (#31353)
@agrohsje commented on this pull request.
________________________________
In GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23discussion-5Fr484915101&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=CtRe2Sebm46t9RG-HQ7APeVquHxl03QXskN6W2YuhGk&e=>:
@@ -8,11 +8,9 @@ using namespace Pythia8;
// leptonic decays
//
…-BiasedTauDecayer::BiasedTauDecayer(const Info* infoPtr,
- Settings* settingsPtr,
- ParticleData* particleDataPtr,
- Rndm* rndmPtr) {
+BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) {
Hi @smrenna<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_smrenna&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=flwDcdfCG85i0nzE3-fpZ52--PYwHlgCWEL5PAtYHoY&e=> . I seems to overlook something. Where do we propagate Settings* settingsPtr to P8, or differently asked, what happens to this argument in BiasedTauDecayer ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23pullrequestreview-2D484136101&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=4StSiFu0mDm8tOHj-xL6op3uS0uNhCd39UFfeKYKLMA&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJEXEBXVNKVIMBESTNTSEZSFNANCNFSM4QU4VZJA&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=93in00QskxXqADwMq3ZLqBae11s7xLjesyRmIVJ9zDQ&s=vog73PUS4zH6n_uATqWWBB90ErXSewqt9peBvsJRNeQ&e=>.
|
|
Hi @smrenna. Sorry, let me rephrase: What is the second argument in BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) used for in the code. I cannot find it. |
|
// Specialized decayer for resonance decays to taus to allowing biasing to
// leptonic decays
//
BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) {
decayer = TauDecays();
decayer.initInfoPtr(*infoPtr);
decayer.init();
filter_ = settingsPtr->flag("BiasedTauDecayer:filter");
eDecays_ = settingsPtr->flag("BiasedTauDecayer:eDecays");
muDecays_ = settingsPtr->flag("BiasedTauDecayer:muDecays");
}
From: agrohsje <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Wednesday, September 9, 2020 at 10:59 AM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Biased tau decayer update (#31353)
Hi @smrenna<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_smrenna&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=xnNjPG-LQrZJdQvoPNuzDv_OEP9cAYj6novmn7EcYlM&e=>. Sorry, let me rephrase: What is the second argument in BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) used for in the code. I cannot find it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23issuecomment-2D689657115&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=s-UF-2iLyiL4nFDuxsFsGBZ_vgqqBY9PBmx0FxnEbEM&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJDLPCLSI66WS6FWOTLSE6Q5TANCNFSM4QU4VZJA&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=D9_WdKdI8ekpLKbJdLEoK4r7Z0WX56GefgamUHc0PKE&e=>.
|
|
Sorry @smrenna. Don't ask me why I overlooked it. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This is an update to the biasedTauDecayer that reflects changes to the structure of
Pythia8.30X. In particular, the way that Pythia8::Info is handled is different.
There is now more protection from allowing an external user to change Info.
PR validation:
The original test (that failed) is passed ZToTauTau_photos_13TeV_rivet_cfg.py
Also, a new test "biasedTauDecayer.py" was added.
if this PR is a backport please specify the original PR and why you need to backport that PR: