Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder #31356

davidlange6 · 2020-09-03T18:33:35Z

as usual - found in module build errors

cmsbuild · 2020-09-03T18:33:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-03T18:39:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31356/18141

This PR adds an extra 12KB to repository

cmsbuild · 2020-09-03T18:39:23Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cvuosalo · 2020-09-03T20:06:10Z

@cmsbuild please test

cmsbuild · 2020-09-03T20:06:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-03-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9113/console Started: 2020/09/03 22:07

cmsbuild · 2020-09-03T22:28:15Z

+1
Tested at: a1fa640
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a64651/9113/summary.html
CMSSW: CMSSW_11_2_X_2020-09-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-03T22:28:17Z

Comparison job queued.

cmsbuild · 2020-09-03T23:58:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a64651/9113/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

smuzaffar · 2020-09-04T06:36:35Z

Geometry/TrackerGeometryBuilder/BuildFile.xml

@@ -7,6 +7,10 @@
 <use name="Geometry/CommonDetUnit"/>
 <use name="Geometry/CommonTopologies"/>
 <use name="Geometry/TrackerNumberingBuilder"/>
+<use name="CondFormats/GeometryObjects"/>


@davidlange6 , looks like this is causing cyclic deps in cxxmodules IBs due to following dep chain

CondFormats/GeometryObjects -> Geometry/VeryForwardGeometryBuilder -> Geometry/TrackerNumberingBuilder -> CondFormats/GeometryObjects

module build failed to compile any thing,

davidlange6 · 2020-09-04T06:39:36Z

Indeed. - however this PR not causing cyclic dependencies. Its admitting to having them.. #31420 is causing them. On Sep 4, 2020, at 8:36 AM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: @smuzaffar commented on this pull request.

________________________________ In Geometry/TrackerGeometryBuilder/BuildFile.xml<#31356 (comment)>:

@@ -7,6 +7,10 @@

<use name="Geometry/CommonDetUnit"/> <use name="Geometry/CommonTopologies"/> <use name="Geometry/TrackerNumberingBuilder"/> +<use name="CondFormats/GeometryObjects"/> @davidlange6<https://github.com/davidlange6> , looks like this is causing cyclic deps in cxxmodules IBs due to following dep chain CondFormats/GeometryObjects -> Geometry/VeryForwardGeometryBuilder -> Geometry/TrackerNumberingBuilder -> CondFormats/GeometryObjects module build failed to compile any thing, — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31356 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2LPSIQQLDF2VZTZXLSECDIHANCNFSM4QVL4XIA>.

smuzaffar · 2020-09-04T06:44:29Z

correct but if this PR along with https://github.com/cms-sw/cmssw/pull/31343/files gets merged then it will break all IBs :-)
By the way, all the cyclic deps can be found under ignominy results https://cmssdt.cern.ch/SDT/cgi-bin/newQA.py?arch=slc7_amd64_gcc820&release=CMSSW_11_2_X_2020-09-03-2300#ignominy

davidlange6 · 2020-09-04T06:47:15Z

On Sep 4, 2020, at 8:44 AM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: correct but if this PR along with https://github.com/cms-sw/cmssw/pull/31343/files gets merged then it will break all IBs :-) Yes, its time to revert #31420. By the way, all the cyclic deps can be found under ignominy results https://cmssdt.cern.ch/SDT/cgi-bin/newQA.py?arch=slc7_amd64_gcc820&release=CMSSW_11_2_X_2020-09-03-2300#ignominy Right - Did you not notice that I fixed 4 of them yesterday?..

davidlange6 · 2020-09-04T11:33:50Z

please test with #31359

cmsbuild · 2020-09-04T11:34:07Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #31359

CMSSW_11_2_X_2020-09-04-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9122/console Started: 2020/09/04 13:34

davidlange6 · 2020-09-04T11:43:01Z

my local full build shows that these two changes work and restore the modules build to a working state (mostly)

cmsbuild · 2020-09-04T14:22:02Z

+1
Tested at: a1fa640
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ad442/9122/summary.html
CMSSW: CMSSW_11_2_X_2020-09-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-04T14:22:09Z

Comparison job queued.

cmsbuild · 2020-09-04T15:51:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ad442/9122/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-09-04T17:18:27Z

+1

cmsbuild · 2020-09-04T17:18:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2020-09-07T07:05:08Z

this pr does not require any external change..

silviodonato · 2020-09-07T08:33:37Z

+1

add included by package

a1fa640

cmsbuild added this to the CMSSW_11_2_X milestone Sep 3, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Sep 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 3, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 3, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 3, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 3, 2020

smuzaffar reviewed Sep 4, 2020

View reviewed changes

davidlange6 changed the title ~~add included by Geometry/Tracker(Numbering/Geometry)Builder~~ Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder Sep 4, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Sep 4, 2020

cmsbuild mentioned this pull request Sep 4, 2020

Revert "Port CTPPS to DD4hep" #31359

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Sep 4, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 4, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Sep 4, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 7, 2020

cmsbuild merged commit 3173c7f into cms-sw:master Sep 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder #31356

Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder #31356

davidlange6 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cvuosalo commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 •

edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

smuzaffar Sep 4, 2020 •

edited

davidlange6 commented Sep 4, 2020 via email

smuzaffar commented Sep 4, 2020

davidlange6 commented Sep 4, 2020 via email

davidlange6 commented Sep 4, 2020

cmsbuild commented Sep 4, 2020 •

edited

davidlange6 commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cvuosalo commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

davidlange6 commented Sep 7, 2020

silviodonato commented Sep 7, 2020

Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder #31356

Add missing includes to Geometry/Tracker(Numbering/Geometry)Builder #31356

Conversation

davidlange6 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cvuosalo commented Sep 3, 2020

cmsbuild commented Sep 3, 2020 • edited

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

smuzaffar Sep 4, 2020 • edited

Choose a reason for hiding this comment

davidlange6 commented Sep 4, 2020 via email

smuzaffar commented Sep 4, 2020

davidlange6 commented Sep 4, 2020 via email

davidlange6 commented Sep 4, 2020

cmsbuild commented Sep 4, 2020 • edited

davidlange6 commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

cvuosalo commented Sep 4, 2020

cmsbuild commented Sep 4, 2020

davidlange6 commented Sep 7, 2020

silviodonato commented Sep 7, 2020

cmsbuild commented Sep 3, 2020 •

edited

smuzaffar Sep 4, 2020 •

edited

cmsbuild commented Sep 4, 2020 •

edited