HCAL: slimmed collections with non-0 noise flags RecHits for miniAOD #31375
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31375/18195
|
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
abdoulline
changed the title
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
DQM bin-by-bin comparison: |
|
Comparison is ready Comparison Summary:
|
|
+reconstruction
|
- for slimmed/reduced muon clusters/extras from cms-sw/cmssw#31217: add some basic plots or `reco::TrackExtra` and the associated pixel/strip clusters - comes with some refactoring of existing plotting methods for the tracker clusters - for slimmedHcalRecHits from cms-sw/cmssw#31375 : basic plots for HBHE/HO/HF hits are added - comes with some refactoring of existing plotting methods for the calo rec hits - add a plot for hbhe rechits chi2 after some minimal energy cut - add pat Electron and Muon BS2D and PV2D plots - adjust the stats text and the exponent label offset for x and y axis plots to avoid/minimize overlapping or invisible text
|
@santocch could you sign, please? |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@abdoulline |
|
Not really, but if there is a need/request, I can do it.
Is it in the context of Laurent's HF-related PRs backported to 10_6_X?
…On Fri, 18 Sep 2020, Slava Krutelyov wrote:
@abdoulline
was this planned to be backported to 10_6_X as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, orunsubscribe.[ABGHJWRPCXU33XF7FOZ6ORTSGN2HVA5CNFSM4Q5VKKQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJ
KTDN5WW2ZLOORPWSZGOFFV3VQY.gif]
|
|
Hello. Yes I think it would be nice to have it in 106X. |
OK Laurent, will do it later today. |
…106X 10_6_X backport of "HCAL: slimmed collections... for miniAOD" (PR #31375)
PR description:
Two tiny-size "simmedHcalRecHits" collections
(HBHERecHitsSorted_slimmedHcalRecHits and HFRecHitsSorted_slimmedHcalRecHits) added to minAOD.
They contain solely RecHits with non-0 (noise) flags set. This is "slimmed" version (without HcalRecHits "interesting" for Egamma) of "reducedHcalRecHits" collections included in AOD.
Having them in minAOD would help to better asses the effect of HCAL noise in physics analyses.
Comes out from a discussion between HCAL DPG and JetMET.
PR validation:
(1)
For 136.88811_RunJetHT2018D... (100 ev) -
reminiAOD (step2) : the size of files: new 10121622, std/reference 10116469 -> factor 1.0005
New collections contain (per 100 ev): 2 HBHERecHits and 13 HF RecHits respectively
(2)
Estimates on bigger statistics
2018D JetHT RelVal with ~3.37*10^5 ev
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/1100pre6_110X_dataRun2_PromptLike_v3_RelVal_2018D-v1_vs_1100pre5_110X_dataRun2_PromptLike_Candidate_2019_08_02_16_53_14_RelVal_2018D-v1_RelVal/JetHT/RecHits/index.html
HBRecHits with non-0 flags ~4x10^-2 / ev
HERecHits with non-0 flags ~6x10^-3 / ev
HFRecHits with non-0 flags ~0.15 / ev
So, 1 RecHit per ~6 JetHT 2018 events.
(3)
runTheMatrix.py -l limited is OK
if this PR is a backport
No