Fix FKDTree unit test #31379
Fix FKDTree unit test #31379
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31379/18201
|
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: CommonTools/RecoAlgos @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
| @@ -46,9 +46,11 @@ void TestFKDTree::test2D() { | |||
| for (unsigned int i = 0; i < numberOfPointsOutsideTheBox; ++i) { | |||
| float x = static_cast<float>(rand()) / (static_cast<float>(RAND_MAX)); | |||
| float y; | |||
There was a problem hiding this comment.
It is probably irrelevant in the context of this unit test, but the y remains undefined if x is outside minX and maxX...
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Small fix in FKDTree unit test. After the fix, the points generated outside the box (numberOfPointsOutsideTheBox) cannot stay on the box faces anymore.
Solve #28841
PR validation:
Run 1000 times
../tmp/slc7_amd64_gcc820/src/CommonTools/RecoAlgos/test/FKDTree_t/FKDTree_twith no error.Previously, I got 2 errors in plain
CMSSW_11_2_X_2020-09-06-2300.