Move PixelBarrelName and PixelEndcapName into TrackerCommon to avoid circular dependency

[davidlange6]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31380/18202

• This PR adds an extra 368KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31380/18202/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31380/18202/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31380/18203

• This PR adds an extra 472KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/TrackerAlignment
CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelQuality
CalibTracker/SiPixelTools
CondCore/SiPixelPlugins
CondFormats/SiPixelObjects
CondTools/SiPixel
DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Summary
DataFormats/SiPixelDetId
DataFormats/TrackerCommon
EventFilter/SiPixelRawToDigi
HLTrigger/special
RecoLocalTracker/SiPixelClusterizer
RecoLuminosity/LumiProducer
SimTracker/SiPixelDigitizer

@perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @tocheng, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @fwyzard, @pohsun can you please review it and eventually sign? Thanks.
@felicepantaleo, @Martin-Grunewald, @fioriNTU, @tlampen, @threus, @mmusich, @seemasharmafnal, @hdelanno, @makortel, @JanFSchulte, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @mschrode, @idebruyn, @ebrondol, @mtosi, @dgulhan, @adewit, @dkotlins, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-06-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9171/console Started: 2020/09/07 14:55

[perrotta]

+1

• Files moved as stated
• Jenkins tests pass

[tlampen]

+alca

[mmusich]

ok, maybe TRK-DPG should have a look and take action

@VinInn please open a CMSSW issue, so it doesn't fall off the radar (given the rather low priority)

[VinInn]

I'll leave it to reco conveners (if they think is worth/relevant/correct)

[mmusich]

I'll leave it to reco conveners (if they think is worth/relevant/correct)

As far as I can tell, the packages involved SiPixelDetId and SiStripDetId are rather under simulation signature:

https://github.com/cms-sw/cms-bot/blob/master/categories_map.py#L1425

https://github.com/cms-sw/cms-bot/blob/master/categories_map.py#L1428

[Martin-Grunewald]

+1

[jfernan2]

+1

[civanch]

+1

[perrotta]

@cms-sw/db-l2 could you please have a look and sign, if you think so? It is just a quite technical PR, and since it involves several files, it is proabably worth trying to merge it now and avoid thus possible conflicts in future...

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1