HCalTopology revision of HE-HF and HB-HE boundaries for |ieta|=16 and 29 #31384
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31384/18212
|
|
A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master. It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The large number of comparison differences need to be investigated and explained. |
Right. This PR fixes an issue of how neighbors are being searched for in PF HCAL clustering around the HE-HF boundary and HB-HE boundary. I expected a little larger effect at HE-HF boundary. Here are PF candidate eta distributions for any particleID. |
|
@hatakeyamak Please add to the PR description, in the Validation section, a statement to the effect that this PR creates widespread small changes related to the HE-HF and HB-HE boundaries to many reconstructed quantities. |
|
@hatakeyamak I would also change the title of this PR to "HCalTopology revision of HE-HF and HB-HE boundaries for |ieta|=16 and 29". It is important to make clear to PdmV and others that this PR is making very noticeable changes; it is not just a minor update. |
Okay. I will do that after having one more look of jenkins test output. Thank you. |
hatakeyamak
changed the title
|
@cvuosalo I made suggested changes to the PR title and added a few more high stat validation results coming from PF validation workflow run on-the-fly. The change in offset quantities show changes mainly in neutral hadrons as expected and jet resolution is either slightly improved or at least not negatively impacted. To me this looks good to go. |
|
+1 |
|
@hatakeyamak Thanks for the clarifications. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
+1 |
PR description:
Update HcalTopology for the ieta neighbor search of |ieta|=16 and 29, i.e. HB-HE boundary and HE-HF boundaries. These two |ieta| values correspind to both HB&HE towers and HE&HF towers. With this update, we specify different behaviors depending on if the tower belongs to HB or HE or to HE or HF [1].
The update will have implications on CaloTopoogy used in PF's navigator for HCAL.
https://cmssdt.cern.ch/lxr/source/RecoParticleFlow/PFClusterProducer/interface/PFHCALDenseIdNavigator.h
Before this update, some 2D layer-wise clusters consisted of rechits of different depths [2]. This will no longer happen with this update [3].
This unexpected behavior was attributed to the HcalTopology behavior as discussed above. In case one is interested in further details: for example, when we are looking for a lower ieta tower of HE ieta=29, we will want to simply decrease ieta by 1 while keeping depth. But, currently, regardless of HF or HE, ieta=29 invokes the special neighbor search which sets the neighbors’s depth to 1. Similarly, for example, when we are looking for the higher ieta for HF ieta=29, we will want to simply increase ieta by 1 while keeping depth. However, currently, regardless of HE or HF, ieta=29 invokes the special neighbor search which sets the neighbor’s depth to 1. These resulted in 2D layer-wise clusters with mixed depth before this PR.
We consulted with @bsunanda (primary author of HcalTopolgy) before this PR was made.
[1] for example, https://cms-docdb.cern.ch/cgi-bin/DocDB/RetrieveFile?docid=12962&filename=HCAL-Depth-Segmentation-Phase1-HE-HBOption1.pdf&version=6
[2] https://indico.cern.ch/event/949951/#12-studies-on-pf-clusters-in-h page-4, 18, 19
[3] https://indico.cern.ch/event/949951/contributions/3991032/attachments/2092837/3527202/plot_PFclusterSize_HFHAD.pdf
@bendavid @bsunanda @abdoulline @garvitaa @iashvili @jsalfeld
PR validation:
The validation is already discussed above. Also checked this update with matrix: 12634.99_TTbar_14TeV (2023PU) and 23434.99_TTbar (2026D49PU) to make sure it runs fine.
This PR creates widespread small changes related to the HE-HF and HB-HE boundaries to many reconstructed quantities.
The PF validation results can be found at:
http://hep.baylor.edu/hatake/PFval/HcalTopologyIeta16And29/
[Highlights]
http://hep.baylor.edu/hatake/PFval/HcalTopologyIeta16And29/OffsetStacks/stack_NuGun_test_vs_NuGun_ref.pdf
show changes consistent with the jenkin's test. Neutral hadrons have largest differences at |eta|=2.7-3.0, and it looks like they are a little more pulled toward loer |eta|. I think this is expected given no (unintended) energy sharing between depths at the 2D clustering stage, which is addressed in this PR.
http://hep.baylor.edu/hatake/PFval/HcalTopologyIeta16And29/FlatQCD_PU_2021_ParticleFlow/JetResponse/slimmedJetsPuppi/noJEC/reso_pt_rms.pdf
Jet energy resolution is either not negatively impacted or slightly improved at the high |eta| endcap.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not backport.