Clean up ME0MuonTrackCollProducer

[perrotta]

PR description:

While reviewing #31190 some possible further cleaning was pointed out in #31190 (comment)
Before forgetting about it, here are the simplifications proposed for the code (plus a few additional ones)

Of course, we wish that some heavier cleaning with the removal from the CMSSW release of all unused ME0 related files can be done at some point: @jshlee @watson-ij @ArnabPurohit @trocino

PR validation:

It compiles
No changes expected

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31386/18224

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

CommonTools/RecoAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @riga, @abbiendi, @jhgoh, @makortel, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9183/console Started: 2020/09/08 14:43

[cmsbuild]

+1
Tested at: 7e35110
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-923e4f/9183/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-923e4f/9183/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609638
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9225/console Started: 2020/09/09 15:20

[cmsbuild]

Pull request #31386 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 20831bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-923e4f/9225/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-923e4f/9225/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2609639
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Some cleanup of a plugin only used in a MuonIdentification test script
• The files have also been moved so that there is no dependence any more of CommonTools/RecoAlgos to RecoMuon/MuonIdentification
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[trocino]

Of course, we wish that some heavier cleaning with the removal from the CMSSW release of all unused ME0 related files can be done at some point: @jshlee @watson-ij @ArnabPurohit @trocino

Sorry for coming back to this a bit late... We are investigating with the GEM community about the use of this ME0-related code, especially ME0MuonSelector of PR #31190 . It may be used — even just in private code — for Phase-II studies. Anyway we will consider how to clean it up, e.g. by merging the ME0MuonSelector with the standard MuonSelectors in DataFormats/MuonReco.

[perrotta]

Of course, we wish that some heavier cleaning with the removal from the CMSSW release of all unused ME0 related files can be done at some point: @jshlee @watson-ij @ArnabPurohit @trocino

Sorry for coming back to this a bit late... We are investigating with the GEM community about the use of this ME0-related code, especially ME0MuonSelector of PR #31190 . It may be used — even just in private code — for Phase-II studies. Anyway we will consider how to clean it up, e.g. by merging the ME0MuonSelector with the standard MuonSelectors in DataFormats/MuonReco.

Thank you Daniele @trocino : I have opened issue #31424 to keep track of it

[makortel]

@smuzaffar The duplicate dictionary checker is now complaining that ME0MuonTrackCollProducer is found in two libraries

pluginCommonToolsRecoAlgos_plugins.so
pluginRecoMuonMuonIdentificationPlugins.so

https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py//slc7_amd64_gcc820/www/thu/11.2-thu-11/CMSSW_11_2_X_2020-09-10-1100/testLogs/dupDict-edmPD.log
I assume this warning will disappear once we get a full build (only patch builds since the merge of this PR for slc7_amd64_gcc820).

But should a file being moved out from a package result that package be built in a patch build?

[smuzaffar]

@makortel , correct , full build should fix this and yes the package from which the file was removed is rebuild in the patch release. But as the dict checking script reads .edmplugincache files (both from patch and full release) to get the list of dicts ( https://github.com/cms-sw/cmssw/blob/master/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py#L249 ) that is why it sees both definitions . I think we can improve it by not reading the plugins which are defined in .poisonededmplugincache.

[makortel]

Thanks, I didn't realize the script was using .edmplugincache (which also explains some confusion I had when checking the content shared object files).

I think we can improve it by not reading the plugins which are defined in .poisonededmplugincache.

Sounds good, thanks.