clean magField->nominalValue()

[mtosi]

PR description:

thanks to @VinInn I realized that in the RecoTracker/TrackProducer/src/TrackProducerAlgorithm.cc there is a fossil related to the usage of the nominal value of the magnetic field and the handling of it if off.
This update is following the usage in other places (like in https://cmssdt.cern.ch/dxr/CMSSW/source/TrackPropagation/SteppingHelixPropagator/plugins/SteppingHelixPropagatorESProducer.cc#72)
in particular, the nominalValue() [1] returns an int which is never negative
and therefore the check has been updated

[1]
https://cmssdt.cern.ch/lxr/source/MagneticField/Engine/interface/MagneticField.h

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31394/18239

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31394/18239/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31394/18239/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31394/18240

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

RecoTracker/TrackProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9200/console Started: 2020/09/08 21:50

[cmsbuild]

+1
Tested at: c168230
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57a239/9200/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57a239/9200/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• It just takes into account that MagneticField::nominalValue() returns an int, and adapts the checks accordingly
• No changes expected, only a few type conversions avoided
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1