Fix BuildFile, use lower case flags tag

[smuzaffar]

SCRAM V3 complains about these flags

Invalid tag 'Flags' found in src/GeneratorInterface/ReggeGribovPartonMCInterface/BuildFile.xml.
Invalid tag 'Flags' found in src/GeneratorInterface/ReggeGribovPartonMCInterface/BuildFile.xml.
Invalid tag 'Flags' found in src/GeneratorInterface/ReggeGribovPartonMCInterface/BuildFile.xml.

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31404/18259

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9216/console Started: 2020/09/09 10:48

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

GeneratorInterface/ReggeGribovPartonMCInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 838cc75
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c233/9216/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Fix scram b code-checks warnings associated with FWCore #31396 @Dr15Jones: Fix scram b code-checks warnings associated with FWCore
• Run4-gem53 Correct a sub-scenario for muon version M8 #31382 @bsunanda: Run4-gem53 Correct a sub-scenario for muon version M8
• Moved headers not needed in interface of Message Logging system #31398 @Dr15Jones: Moved headers not needed in interface of Message Logging system
• Phase2-sim73 Add provision different regions for fine detectors #31357 @bsunanda: Phase2-sim73 Add provision different regions for fine detectors
• Phase2-gem53 Preparation for a new muon scenario with GE0 rather than ME0 #31367 @bsunanda: Phase2-gem53 Preparation for a new muon scenario with GE0 rather than ME0

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c233/9216/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c233/9216/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c233/9216/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[davidlange6]

are these flags actually needed? Eg, was this incorrect for the past many errors, or does scramv2 correct this error?

[smuzaffar]

looks like these flags are used in https://github.com/cms-sw/cmssw/blob/master/GeneratorInterface/ReggeGribovPartonMCInterface/src/models.F

[davidlange6]

Right - my question is if we've had this behavior the last ten years, are we sure we want to change it? It looks like it only turns on/off functionality in the package, so fixing that is safe enough.

[smuzaffar]

behaviour is not changed. It is only that SCRAM V2 was not case sensitive so these flags were always set [a] by SCRAM V2.
With SCRAM V3, I would like to make it case sensitive (every thing is alredy lower case any way) and warns about these flags (but still use set them[b] to not break any thing).

[a]
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-07-1100/GeneratorInterface/ReggeGribovPartonMCInterface

[b]
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_SCRAMV3_X_2020-09-08-1100/GeneratorInterface/ReggeGribovPartonMCInterface

[davidlange6]

Ok, thanks for the confirmation - thanks! On Sep 9, 2020, at 4:33 PM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: behaviour is not changed. It is only that SCRAM V2 was not case sensitive so these flags were always set [a] by SCRAM V2. With SCRAM V3, I would like to make it case sensitive (every thing is alredy lower case any way) and warns about these flags (but still use set them[b] to not break any thing). [a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-09-07-1100/GeneratorInterface/ReggeGribovPartonMCInterface [b] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_SCRAMV3_X_2020-09-08-1100/GeneratorInterface/ReggeGribovPartonMCInterface — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#31404 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQYX472O7WTEUMORENDSE6G4FANCNFSM4RBRI3QQ>.

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1