Improve SwitchProducer error message for inconsistent output products #31414

makortel · 2020-09-09T19:46:31Z

PR description:

This PR resolves (partially) #31230. The exception message includes now a suggestion to use EDAlias, and lists the products (friendly class name and product instance name) for all cases, along

  SwitchProducer s has a case s@test1 that does not produce a product BranchKey
  (edmtestIntProduct, s, foo, TEST) that is produced by the chosen case
  s@test2. If the intention is to produce only a subset of the products listed
  below, each case with more products needs to be replacated with an EDAlias to
  only the necessary products, and the EDProducer itself needs to be moved to a
  Task.
  
  Products for case s@test1 (friendly class name, product instance name):
   edmtestIntProduct 
  Products for case s@test2 (friendly class name, product instance name):
   edmtestIntProduct 
   edmtestIntProduct foo

PR validation:

Framework unit tests succeed

cmsbuild · 2020-09-09T19:46:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-09T19:52:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31414/18281

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/src/Schedule.cc modified in PR(s): Use TransitionInfo in more interfaces, part 2 #31136, Delete unscheduled modules that are not consumed by any scheduled module #29553, Use TransitionInfo in more interfaces #30969

cmsbuild · 2020-09-09T19:53:13Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2020-09-09T19:53:23Z

@cmsbuild, please test

cmsbuild · 2020-09-09T19:53:37Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9236/console Started: 2020/09/09 21:55

makortel · 2020-09-09T19:54:53Z

FWCore/Integration/test/SwitchProducer_t.cpp

-    REQUIRE_THROWS(edm::test::TestProcessor(config1),
-                   Catch::Contains("with a product") && Catch::Contains("that is not produced by the chosen case"));
+    REQUIRE_THROWS_WITH(
+        edm::test::TestProcessor(config2),


This one (and similar change below) actually fix a bug in the test as well. This test should have used config2 already before, but was not caught with the Catch::Contains because the test mistakenly used REQUIRE_THROWS instead of REQUIRE_THROWS_WITH.

fwyzard · 2020-09-09T20:26:39Z

Thank, this will definitely come useful for building a combined CPU/GPU workflow for the Pixel, ECAL and HCAL workflows !

wddgit · 2020-09-09T20:47:26Z

FWCore/Framework/src/Schedule.cc

+                   << proc_pset.getParameter<edm::ParameterSet>(switchLabel)
+                          .getUntrackedParameter<std::string>("@chosen_case")
+                   << ". If the intention is to produce only a subset of the products listed below, each case with "
+                      "more products needs to be replacated with an EDAlias to only the necessary products, and the "


replacate -> replicate

Thanks @wddgit! Although I probably meant "replaced".

cmsbuild · 2020-09-09T21:14:54Z

+1
Tested at: 6860ce4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30a1aa/9236/summary.html
CMSSW: CMSSW_11_2_X_2020-09-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-09T21:14:57Z

Comparison job queued.

cmsbuild · 2020-09-09T22:49:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30a1aa/9236/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609638
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

…consistency exception Also fix two mistakes in the unit test.

cmsbuild · 2020-09-09T23:44:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-09T23:51:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31414/18282

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/src/Schedule.cc modified in PR(s): Use TransitionInfo in more interfaces, part 2 #31136, Delete unscheduled modules that are not consumed by any scheduled module #29553, Use TransitionInfo in more interfaces #30969

cmsbuild · 2020-09-09T23:51:45Z

Pull request #31414 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

makortel · 2020-09-09T23:53:49Z

@cmsbuild, please test

cmsbuild · 2020-09-09T23:54:13Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9238/console Started: 2020/09/10 01:54

cmsbuild · 2020-09-10T01:11:34Z

+1
Tested at: c4c0f52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30a1aa/9238/summary.html
CMSSW: CMSSW_11_2_X_2020-09-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-10T01:11:37Z

Comparison job queued.

cmsbuild · 2020-09-10T04:16:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30a1aa/9238/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-09-10T18:24:57Z

+1

cmsbuild · 2020-09-10T18:25:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-09-10T20:38:11Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Sep 9, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Sep 9, 2020

makortel mentioned this pull request Sep 9, 2020

improve the SwitchProducer error message to suggest a solution #31230

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 9, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2020

makortel commented Sep 9, 2020

View reviewed changes

wddgit reviewed Sep 9, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Sep 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 9, 2020

Include product types and instance names to SwitchProducer product in…

c4c0f52

…consistency exception Also fix two mistakes in the unit test.

makortel force-pushed the switchProducerTypesInException branch from 6860ce4 to c4c0f52 Compare September 9, 2020 23:44

cmsbuild removed the code-checks-approved label Sep 9, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Sep 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 9, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 10, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 10, 2020

cmsbuild merged commit 67425f0 into cms-sw:master Sep 10, 2020

makortel deleted the switchProducerTypesInException branch September 10, 2020 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve SwitchProducer error message for inconsistent output products #31414

Improve SwitchProducer error message for inconsistent output products #31414

makortel commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

makortel commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 •

edited

makortel Sep 9, 2020

fwyzard commented Sep 9, 2020

wddgit Sep 9, 2020

makortel Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

makortel commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 •

edited

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

makortel commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

silviodonato commented Sep 10, 2020

Improve SwitchProducer error message for inconsistent output products #31414

Improve SwitchProducer error message for inconsistent output products #31414

Conversation

makortel commented Sep 9, 2020

PR description:

PR validation:

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

makortel commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 • edited

makortel Sep 9, 2020

Choose a reason for hiding this comment

fwyzard commented Sep 9, 2020

wddgit Sep 9, 2020

Choose a reason for hiding this comment

makortel Sep 9, 2020

Choose a reason for hiding this comment

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

makortel commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 • edited

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

makortel commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

silviodonato commented Sep 10, 2020

cmsbuild commented Sep 9, 2020 •

edited

cmsbuild commented Sep 9, 2020 •

edited