HF jet shower shape (106X backport) #31420

lathomas · 2020-09-10T08:56:08Z

PR description:

This PR computes a few shower shape related variables for HF jets that are then added as userFloats/userInts to AK4 CHS jets. The variables are also added to NANOAOD.
Such variables turn out to be useful to discriminate physics jets from noise.

The description of the variables and their motivation can be found in this talk:
https://indico.cern.ch/event/944298/#sc-10-4-hf-noise-study-on-aod

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #31271
Needed for UL reMINIAOD

cmsbuild · 2020-09-10T08:56:35Z

A new Pull Request was created by @lathomas for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
RecoJets/JetProducers

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @yslai, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Shower shape variables for HF jets #31271

perrotta · 2020-09-10T09:09:46Z

backport of #31271

perrotta · 2020-09-10T09:09:56Z

please test

cmsbuild · 2020-09-10T09:10:07Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-09-09-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9245/console Started: 2020/09/10 11:10

cmsbuild · 2020-09-10T10:34:19Z

+1
Tested at: cd96acc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3db2/9245/summary.html
CMSSW: CMSSW_10_6_X_2020-09-09-2300
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-09-10T10:34:21Z

Comparison job queued.

cmsbuild · 2020-09-10T12:33:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3db2/9245/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 132 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214631
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214296
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3.625 KiB( 33 files compared)
DQMHistoSizes: changed ( 1325.7 ): 3.625 KiB Physics/NanoAODDQM
Checked 140 log files, 14 edm output root files, 34 DQM output files

slava77 · 2020-09-11T00:21:04Z

Reco comparison results: 132 differences found in the comparisons

this triggers updates in all workflows, which technically is agains the no-change requirement.
Please update to add the new data only with run2_miniAOD_UL in the miniAOD workflows.

slava77 · 2020-09-11T00:26:31Z

PhysicsTools/NanoAOD/python/jets_cff.py

+
+

Suggested change

not in master

slava77 · 2020-09-11T01:25:54Z

PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

+    process.patJets.userData.userFloats.src += [ 'hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi']
+    process.patJets.userData.userInts.src += [ 'hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize']


Suggested change

process.patJets.userData.userFloats.src += [ 'hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi']

process.patJets.userData.userInts.src += [ 'hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize']

run2_miniAOD_UL.toModify(process.patJets.userData.userFloats,

src = process.patJets.userData.userFloats.src + ['hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi'])

run2_miniAOD_UL.toModify(process.patJets.userData.userInts,

src = process.patJets.userData.userInts.src + ['hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize'])

to protect the extension with the modifier

cmsbuild · 2020-09-17T00:46:12Z

Pull request #31420 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please check and sign again.

slava77 · 2020-09-17T00:55:38Z

@cmsbuild please test

cmsbuild · 2020-09-17T00:56:00Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-09-16-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9390/console Started: 2020/09/17 02:56

cmsbuild · 2020-09-17T02:18:11Z

+1
Tested at: c197c9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3db2/9390/summary.html
CMSSW: CMSSW_10_6_X_2020-09-16-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-09-17T02:18:13Z

Comparison job queued.

cmsbuild · 2020-09-17T09:59:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3db2/9390/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 30 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214632
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214296
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3.625 KiB( 33 files compared)
DQMHistoSizes: changed ( 1325.7 ): 3.625 KiB Physics/NanoAODDQM
Checked 140 log files, 14 edm output root files, 34 DQM output files

mariadalfonso · 2020-09-17T17:50:35Z

+xpog

slava77 · 2020-09-17T21:55:40Z

+1

for #31420 c197c9d

changes applied since the last reco signoff were outside/downstream from reco https://github.com/cms-sw/cmssw/pull/31420/files/224bd242f5a4eb9447b5dc3bb67e4320b4b924ca..c197c9d51fc5440aec42e450eb48e4e7c22d2eda
jenkins tests pass

santocch · 2020-09-18T16:20:56Z

+1

cmsbuild · 2020-09-18T16:21:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-19T01:12:40Z

+1

HF jet shower shape (106X backport)

cd96acc

cmsbuild added this to the CMSSW_10_6_X milestone Sep 10, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Sep 10, 2020

cmsbuild added backport tests-started and removed tests-pending labels Sep 10, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 10, 2020

mariadalfonso mentioned this pull request Sep 10, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

cmsbuild added backport-ok and removed backport labels Sep 10, 2020

slava77 reviewed Sep 11, 2020

View reviewed changes

Small synch to master + new products behind an era customizer

bc604fa

cmsbuild removed the comparison-available label Sep 11, 2020

cmsbuild added the tests-pending label Sep 17, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 17, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 17, 2020

slava77 mentioned this pull request Sep 17, 2020

features for UL re-miniAOD in 10_6_X #27889

Closed

41 tasks

cmsbuild added xpog-approved and removed xpog-pending labels Sep 17, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 17, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Sep 18, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 19, 2020

cmsbuild merged commit 4ae4f24 into cms-sw:CMSSW_10_6_X Sep 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HF jet shower shape (106X backport) #31420

HF jet shower shape (106X backport) #31420

lathomas commented Sep 10, 2020

cmsbuild commented Sep 10, 2020 •

edited

perrotta commented Sep 10, 2020

perrotta commented Sep 10, 2020

cmsbuild commented Sep 10, 2020 •

edited

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

slava77 commented Sep 11, 2020

slava77 Sep 11, 2020

slava77 Sep 11, 2020

cmsbuild commented Sep 17, 2020

slava77 commented Sep 17, 2020

cmsbuild commented Sep 17, 2020 •

edited

cmsbuild commented Sep 17, 2020

cmsbuild commented Sep 17, 2020

cmsbuild commented Sep 17, 2020

mariadalfonso commented Sep 17, 2020

slava77 commented Sep 17, 2020

santocch commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

qliphy commented Sep 19, 2020

		process.patJets.userData.userFloats.src += [ 'hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi']
		process.patJets.userData.userInts.src += [ 'hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize']

-    process.patJets.userData.userFloats.src += [ 'hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi']
-    process.patJets.userData.userInts.src += [ 'hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize']
+    run2_miniAOD_UL.toModify(process.patJets.userData.userFloats,
+                             src = process.patJets.userData.userFloats.src + ['hfJetShowerShape:sigmaEtaEta', 'hfJetShowerShape:sigmaPhiPhi'])
+    run2_miniAOD_UL.toModify(process.patJets.userData.userInts,
+                             src = process.patJets.userData.userInts.src + ['hfJetShowerShape:centralEtaStripSize', 'hfJetShowerShape:adjacentEtaStripsSize'])

HF jet shower shape (106X backport) #31420

HF jet shower shape (106X backport) #31420

Conversation

lathomas commented Sep 10, 2020

PR description:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 10, 2020 • edited

perrotta commented Sep 10, 2020

perrotta commented Sep 10, 2020

cmsbuild commented Sep 10, 2020 • edited

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

cmsbuild commented Sep 10, 2020

slava77 commented Sep 11, 2020

slava77 Sep 11, 2020

Choose a reason for hiding this comment

slava77 Sep 11, 2020

Choose a reason for hiding this comment

cmsbuild commented Sep 17, 2020

slava77 commented Sep 17, 2020

cmsbuild commented Sep 17, 2020 • edited

cmsbuild commented Sep 17, 2020

cmsbuild commented Sep 17, 2020

cmsbuild commented Sep 17, 2020

mariadalfonso commented Sep 17, 2020

slava77 commented Sep 17, 2020

santocch commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

qliphy commented Sep 19, 2020

cmsbuild commented Sep 10, 2020 •

edited

cmsbuild commented Sep 10, 2020 •

edited

cmsbuild commented Sep 17, 2020 •

edited