Fixed MUON System overlaps for DD4hep Scenario 2021 #31434
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31434/18306
|
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
Are 50 cm overlaps real? Is it something new? |
|
I shall have a look - do we have a most up-to-date PPS in the IB?
…________________________________
From: Sergio Lo Meo [notifications@github.com]
Sent: 11 September 2020 16:44
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Fixed MUON System overlaps for DD4hep Scenario 2021 (#31434)
Are 50 cm overlaps real? Is it something new?
No, it is not new. I attached the same picure 10 days ago (before this PR), please see my post to @bsunanda<https://github.com/bsunanda> in the PR #31182<#31182>. The 50 cm overlaps are not in MUON... I don't know if they are real or not... I hope no
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31434 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOU27S7GCGGGTG6UUN3SFIZUXANCNFSM4RHRYVTA>.
|
|
-1 Tested at: 17c34f1 CMSSW: CMSSW_11_2_X_2020-09-11-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test2021Geometry had ERRORS |
|
Comparison job queued. |
|
I'm reading the log of the failed test, but I don't understand exactly what is the error? This one: "===== Test "test2021Geometry" ==== or DD4CMS ERROR +++ Placement FAILED! Parent:CMSE Child:tracker:Tracker Valid:NO ? |
|
@slomeo you have to update all relevant geometries in the geometry script: |
|
Comparison is ready Comparison Summary:
|
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@slomeo In the PR description, please write that the picture shows, after this PR, no Muon overlaps but apparent remaining overlaps in PPS and ZDC. |
|
+1 |
|
Hi Sergio. Can you make a comment with the list of remaining overlaps in
CMS from your (g4) logs in the issue please? (To keep it updated) Thanks a
lot!
|
|
@vargasa : please find below (see [+]) what you requested. CAVEAT: in this list I added only the name of the volumes where are present overlaps but the number of the overlaps is greater than then the number of the volumes listed here, for example: Overlap is detected for volume EHAWR_1:1 (G4SubtractionSolid) with EHAWR_2:2 (i.e EHAWR_2:2 is cited two times, and so on) For the complete list please see /afs/cern.ch/user/s/slomeo/public/Overlaps/overlaps.out [+] |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
I see you updated #31182 with the overlaps |
|
+1 |
PR description:
This PR has been triggered by what @vargasa wrote in PR #31182. All the overlaps inside the MUON System have been fixed.
PR validation:
validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
The attached picture shows, after this PR, no Muon overlaps but apparent remaining overlaps in PPS and ZDC.
validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
Before this PR the result was: /afs/cern.ch/user/s/slomeo/public/Overlaps/overlaps.out.orig (i.e YB* volumes have some overlaps)
After this PR the result is: /afs/cern.ch/user/s/slomeo/public/Overlaps/overlaps.out (i.e there are not YB* volumes anymore)
25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Fri Sep 11 12:27:34 2020-date Fri Sep 11 12:06:10 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special