Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: direct simulation with xangle distributions #31453

Merged
merged 4 commits into from Sep 15, 2020

Conversation

jan-kaspar
Copy link
Contributor

PR description:

This is a mostly technical change, making it easier to run the PPS "direct" simulation with realistic xangle distributions (extracted from data). For more details, please refer to this Proton POG presentation

PR validation:

The direct simulation is not included in any central workflows (neither in matrix tests). Therefore no changes are expected there.

Some validation plots are available in the above-linked POG presentation.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31453/18342

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers
Validation/CTPPS

@andrius-k, @kmaeshima, @christopheralanwest, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@forthommel, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 74405c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-187458/9314/summary.html
CMSSW: CMSSW_11_2_X_2020-09-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-187458/9314/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620306
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2620272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@tlampen
Copy link
Contributor

tlampen commented Sep 15, 2020

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 15, 2020

+1

@cmsbuild cmsbuild merged commit d149158 into cms-sw:master Sep 15, 2020
@jan-kaspar jan-kaspar deleted the pps_systematics_rebased branch September 21, 2020 09:38
@jan-kaspar jan-kaspar restored the pps_systematics_rebased branch September 23, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants