Adding check to ensure L1Menu consistency in the HLT : 112X #31461

Sam-Harper · 2020-09-14T19:20:12Z

PR description:

The L1 result is packed into the RAW data as 512 bits which each bit corresponding to a given L1 seed. Which seed corresponds to a given bit is determined by the L1 menu which is sent as conditions data. It is possible for the wrong L1 menu to be read if the corresponding entry in the global tag is incorrect. In this case the bits will not correspond to the L1 seeds the HLT thinks they do and thus when it thinks its requiring EG40 to pass, its really requiring Mu16 (as a hypothetical example).

This PR adds the function which can convert the the firmware uuid to the hash of the firmware uuid send in the RAW data along with the L1 results. This can be then checked by the L1 GT emulator (L1TGlobalProducer) to ensure that the correct menu is being re-emulated and throw an exception if not.

Note L1TGlobalProducer has two distinct use cases

to emulate the L1 Global trigger when emulating the L1 in the MC or emulating a different L1 menu on the data
to create the map of L1 objects to seeds which is needed for the HLT to properly use the seeds in its filters

It is use case 2) where we need to check that the menu we are emulating to create the l1 object map is the same as the menu used to create the L1 result in the RAW data. This is why this is an optional check (which will always be enabled in the HLT) as it doesnt make sense for use case 1)

Zero physics changes are expected.

PR validation:

runTheMatrix tests succeeded.

testing with the incorrect menu resulted in the exception being thrown

…menu as the L1 originally used

cmsbuild · 2020-09-14T19:20:36Z

The code-checks are being triggered in jenkins.

Sam-Harper · 2020-09-14T19:21:31Z

@Martin-Grunewald: FYI

cmsbuild · 2020-09-14T19:26:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31461/18366

This PR adds an extra 32KB to repository

cmsbuild · 2020-09-14T19:26:40Z

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

CondFormats/L1TObjects
L1Trigger/L1TGlobal

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2020-09-15T05:16:20Z

please test

cmsbuild · 2020-09-15T05:16:42Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9339/console Started: 2020/09/15 15:07

cmsbuild · 2020-09-15T14:42:50Z

+1
Tested at: e58937d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8351b/9339/summary.html
CMSSW: CMSSW_11_2_X_2020-09-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-15T14:42:52Z

Comparison job queued.

cmsbuild · 2020-09-15T16:11:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8351b/9339/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2620306
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2620272
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-09-18T10:59:22Z

Any comments from @cms-sw/alca-l2 @cms-sw/db-l2 @cms-sw/l1-l2 ?

tlampen · 2020-09-18T12:05:26Z

+alca

Sam-Harper · 2020-09-29T16:52:21Z

Hi @cavana, thanks. You can also see https://hypernews.cern.ch/HyperNews/CMS/get/L1TriggerSW/869.html for more details. Its been bubbling along for a while (it got L1 TDRed and then covided leading to large delays)

cavana · 2020-09-30T13:46:08Z

Hi @Sam-Harper, many thanks for this development and glad to hear that you are back to healthy -- I'm not sure which is worse, being TDRed or covided :-). I've quickly reviewed the PR and it looks good to me -- I'm happy to endorse it. Thanks for your patience as I try to come up to speed with all things uGT emulator. Best wishes, Rick

Sam-Harper · 2020-09-30T14:01:43Z

Thanks. And for covid, I meant, it fell by the wayside of general covid chaos and disruption (it was being discussed in late march) and was forgotten about, not that I got covid!

Thanks for endorsing it, this will greatly increase the robustness of the HLT

silviodonato · 2020-09-30T16:01:56Z

please test
I will merge this PR in the evening IB
@rekovic I take @cavana's comment as a +1 from l1

cmsbuild · 2020-09-30T16:02:15Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9668/console Started: 2020/09/30 18:03

cmsbuild · 2020-09-30T17:36:01Z

+1
Tested at: e58937d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8351b/9668/summary.html
CMSSW: CMSSW_11_2_X_2020-09-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-30T17:36:03Z

Comparison job queued.

cmsbuild · 2020-09-30T19:04:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8351b/9668/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-09-30T19:09:18Z

merge

rekovic · 2020-10-01T07:23:21Z

+1

cmsbuild · 2020-10-01T07:23:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

makortel · 2020-10-01T14:39:07Z

CondFormats/L1TObjects/src/L1TUtmTriggerMenu.cc

+      h ^= data[2] << 16;
+    case 2:
+      h ^= data[1] << 8;
+    case 1:


@Sam-Harper Is the purpose of case 3: and case 2: to fall through (i.e. is the break; omitted on purpose)?

(spotted by gcc 9 warnings)

no idea. This is was copied from https://gitlab.cern.ch/cms-l1t-utm/utm/-/blob/master/tmUtil/tmUtil.cc

Do you know who would know?

no, @rekovic might know though. Here we are emulating firmware deployed at p5 though. So even if it is "buggy" its still correct I think as long as it agrees with the hardware output at p5.

@makortel @Sam-Harper , looks like the fall through is on purpose. I have opened a PR #31828 to silence GCC 9 warnings

adding check to L1TGlobalProducer to force it to emulate the same L1 …

e58937d

…menu as the L1 originally used

cmsbuild added this to the CMSSW_11_2_X milestone Sep 14, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending l1-pending orp-pending pending-signatures tests-pending labels Sep 14, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 15, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 15, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 15, 2020

cmsbuild removed the alca-pending label Sep 18, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Sep 30, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 30, 2020

cmsbuild merged commit d0c137b into cms-sw:master Sep 30, 2020

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Oct 1, 2020

makortel reviewed Oct 1, 2020

View reviewed changes

smuzaffar mentioned this pull request Oct 16, 2020

[GCC9]Add explicit fallthrough attribute to fix gcc9 warnings #31828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding check to ensure L1Menu consistency in the HLT : 112X #31461

Adding check to ensure L1Menu consistency in the HLT : 112X #31461

Sam-Harper commented Sep 14, 2020 •

edited

cmsbuild commented Sep 14, 2020

Sam-Harper commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

Martin-Grunewald commented Sep 15, 2020

cmsbuild commented Sep 15, 2020 •

edited

cmsbuild commented Sep 15, 2020

cmsbuild commented Sep 15, 2020

cmsbuild commented Sep 15, 2020

silviodonato commented Sep 18, 2020

tlampen commented Sep 18, 2020

Sam-Harper commented Sep 29, 2020

cavana commented Sep 30, 2020

Sam-Harper commented Sep 30, 2020

silviodonato commented Sep 30, 2020

cmsbuild commented Sep 30, 2020 •

edited

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

silviodonato commented Sep 30, 2020

rekovic commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

makortel Oct 1, 2020

Sam-Harper Oct 2, 2020

makortel Oct 2, 2020

Sam-Harper Oct 2, 2020

smuzaffar Oct 16, 2020

Adding check to ensure L1Menu consistency in the HLT : 112X #31461

Adding check to ensure L1Menu consistency in the HLT : 112X #31461

Conversation

Sam-Harper commented Sep 14, 2020 • edited

PR description:

PR validation:

cmsbuild commented Sep 14, 2020

Sam-Harper commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

Martin-Grunewald commented Sep 15, 2020

cmsbuild commented Sep 15, 2020 • edited

cmsbuild commented Sep 15, 2020

cmsbuild commented Sep 15, 2020

cmsbuild commented Sep 15, 2020

silviodonato commented Sep 18, 2020

tlampen commented Sep 18, 2020

Sam-Harper commented Sep 29, 2020

cavana commented Sep 30, 2020

Sam-Harper commented Sep 30, 2020

silviodonato commented Sep 30, 2020

cmsbuild commented Sep 30, 2020 • edited

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

silviodonato commented Sep 30, 2020

rekovic commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

makortel Oct 1, 2020

Choose a reason for hiding this comment

Sam-Harper Oct 2, 2020

Choose a reason for hiding this comment

makortel Oct 2, 2020

Choose a reason for hiding this comment

Sam-Harper Oct 2, 2020

Choose a reason for hiding this comment

smuzaffar Oct 16, 2020

Choose a reason for hiding this comment

Sam-Harper commented Sep 14, 2020 •

edited

cmsbuild commented Sep 15, 2020 •

edited

cmsbuild commented Sep 30, 2020 •

edited