Changes to improve GE0 GEMSegments #31480

watson-ij · 2020-09-16T09:10:38Z

PR description:

These changes allow GE0 GEMSegments in GEM to act the same as the current ME0Segment:

Add deltaPhi to GEMSegments to match the ME0Segment
Copied the deltaPhi calculator to GEMSuperChamber from ME0Chamber (which is actually the equivalent of GEMSuperChamber)
Adapted ME0SegAlgRU to GE0SegAlgRU so the RU segment finder can run from GEM RecHits (for now, keep default GEMSegmentBuilder, but we may later want to switch to GE0SegAlgRU, or split the algorithm used for GE0 and GE[12]/1)

@jshlee @dildick Since we are updating the GEMSegment with deltaPhi and therefore changing the GEMSegment interface anyway, I went ahead and removed the timing information from GEMSegments. The GEM only outputs bunch crossing information, and from what I've been told there's no plan to include timing, so I think this info is unused and not planned to be used in the future. Let me know if you prefer to reverse these changes.

PR validation:

I checked runTheMatrix 24821.0 (TenMuE) with the GE0Geometry in Geometry/GEMGeometry up to DIGI + GEM RecoHit/Segment reconstruction. Segments look to be made correctly, all stations (including GE0) are producing them with the current setup.
I also checked the GE0SegAlgRU produces segments, but we should compare the ME0Segments and GE0Segments produced later, once the whole pipeline is working.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

GE0 is now controlled by a separate algorithm in GEMSegmentBuilder.

We want to use only one algorithm for the whole GEM (for now, need to study the different algorithms on the different subdetectors)

Also remove unused timing information, since the GEM detectors keep bunch crossing info (in theBX), not timing.

cmsbuild · 2020-09-16T09:11:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-16T09:16:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31480/18396

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31480/18396/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31480/18396/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-09-16T09:23:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-16T09:29:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31480/18397

This PR adds an extra 40KB to repository

cmsbuild · 2020-09-16T09:29:45Z

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

DataFormats/GEMRecHit
Geometry/GEMGeometry
RecoLocalMuon/GEMSegment

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @jpata can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @Fedespring, @jshlee, @calderona, @HuguesBrun, @jhgoh, @dildick, @cericeci, @rovere, @trocino, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-09-16T09:40:28Z

please test

cmsbuild · 2020-09-16T09:40:50Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9373/console Started: 2020/09/16 11:43

cmsbuild · 2020-09-16T11:55:20Z

+1
Tested at: d073f01
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783c0/9373/summary.html
CMSSW: CMSSW_11_2_X_2020-09-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

[DD4hep] Start Core Code Cleanup #31454 @ianna: [DD4hep] Start Core Code Cleanup
Initialize vars to nullptr in HTXSRivetProducer, fix #31474 #31476 @mrodozov: Initialize vars to nullptr in HTXSRivetProducer, fix New rivet version fails ASAN relvals with sygsegv #31474

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783c0/9373/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783c0/9373/git-merge-result

cmsbuild · 2020-09-16T11:55:23Z

Comparison job queued.

cmsbuild · 2020-09-22T09:40:37Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-21-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9485/console Started: 2020/09/22 11:41

perrotta · 2020-09-22T09:42:22Z

Actually, no, I spoke too soon, the reason we are using double there is that we inherit from RecSegment which requires double chi2 in the interface. I've reverted the changes

I'm convinced that it could be more conveniently migrated everywhere, thus avoiding type conversions back and forth from float to double... But I agree that it is not something that has to be dealt with in this PR

cmsbuild · 2020-09-22T11:47:43Z

+1
Tested at: 593bea0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783c0/9485/summary.html
CMSSW: CMSSW_11_2_X_2020-09-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-22T11:47:45Z

Comparison job queued.

cmsbuild · 2020-09-22T13:17:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4783c0/9485/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2540471
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2540448
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

kpedro88 · 2020-09-22T15:19:44Z

+upgrade

cvuosalo · 2020-09-22T17:03:02Z

+1

perrotta · 2020-09-24T10:25:19Z

+1

It adapts GEMSegments to allow GE0 in them
A new GE0SegAlgRU plugin is also introduced here: it will eventually replace the ME0SegAlgRU one, but it is not yet inserted by default in the Phase2 pipeline
- Some code overlap with ME0SegAlgRU is unavoidable: it will become irrelevant once ME0SegAlgRU will be dropped
Jenkins tests pass and show only differences for the removed time variable that was still there in the previous GEMSegment
GE0SegAlgRU not tested with the central tests because not yet included in the default reco: a validation has been performed by the authors, and reported in the PR description

cmsbuild · 2020-09-24T10:25:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-09-24T16:19:25Z

RecoLocalMuon/GEMSegment/python/gemSegments_cfi.py

+# defaults for GE0SegAlgoRU
+RU_GE0 = cms.PSet(
+    allowWideSegments = cms.bool(True),
+    doCollisions = cms.bool(True),
+    maxChi2Additional = cms.double(100.0),
+    maxChi2Prune = cms.double(50),
+    maxChi2GoodSeg = cms.double(50),
+    maxPhiSeeds = cms.double(0.001096605744), #Assuming 384 strips
+    maxPhiAdditional = cms.double(0.001096605744), #Assuming 384 strips
+    maxETASeeds = cms.double(0.1), #Assuming 8 eta partitions
+    maxTOFDiff = cms.double(25),
+    requireCentralBX = cms.bool(True), #require that a majority of hits come from central BX
+    minNumberOfHits = cms.uint32(4),
+    maxNumberOfHits = cms.uint32(300),
+    maxNumberOfHitsPerLayer = cms.uint32(100),
+)
+


Why did you add RU_GE0 in gemSegments_cfi.py? This file should contain only the default values of gemSegments

Because this is the default for the RU algorithm, which is the default reconstruction for ME0. For GE0, we will have a student check the various segment algorithms and possibly add the option to change algorithm by station, so I wanted to have this here to make it easy for them to switch algorithms.

silviodonato · 2020-09-25T07:25:35Z

+1

watson-ij added 3 commits September 16, 2020 17:50

Copy (and get working) ME0 RU segment algo as GE0

33a7e8d

GE0 is now controlled by a separate algorithm in GEMSegmentBuilder.

Reverse the changes to the GEMSegmentBuilder

fec279d

We want to use only one algorithm for the whole GEM (for now, need to study the different algorithms on the different subdetectors)

Add deltaPhi to GEMSegment, for GE0 merging (i.e. merge ME0Segment info)

a906a51

Also remove unused timing information, since the GEM detectors keep bunch crossing info (in theBX), not timing.

cmsbuild added this to the CMSSW_11_2_X milestone Sep 16, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Sep 16, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 16, 2020

Code format

d073f01

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 22, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 22, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 22, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 22, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Sep 22, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 24, 2020

silviodonato reviewed Sep 24, 2020

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Sep 25, 2020

cmsbuild merged commit df16751 into cms-sw:master Sep 25, 2020

cmsbuild mentioned this pull request Sep 25, 2020

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

Merged

perrotta mentioned this pull request Feb 27, 2021

Separate Algorithms for GE0 and GE1/1 GE2/1 Segments #32972

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to improve GE0 GEMSegments #31480

Changes to improve GE0 GEMSegments #31480

watson-ij commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

perrotta commented Sep 16, 2020

cmsbuild commented Sep 16, 2020 •

edited

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 22, 2020 •

edited

perrotta commented Sep 22, 2020 •

edited

cmsbuild commented Sep 22, 2020

cmsbuild commented Sep 22, 2020

cmsbuild commented Sep 22, 2020

kpedro88 commented Sep 22, 2020

cvuosalo commented Sep 22, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

silviodonato Sep 24, 2020

watson-ij Sep 25, 2020

silviodonato commented Sep 25, 2020

Changes to improve GE0 GEMSegments #31480

Changes to improve GE0 GEMSegments #31480

Conversation

watson-ij commented Sep 16, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

perrotta commented Sep 16, 2020

cmsbuild commented Sep 16, 2020 • edited

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 16, 2020

cmsbuild commented Sep 22, 2020 • edited

perrotta commented Sep 22, 2020 • edited

cmsbuild commented Sep 22, 2020

cmsbuild commented Sep 22, 2020

cmsbuild commented Sep 22, 2020

kpedro88 commented Sep 22, 2020

cvuosalo commented Sep 22, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

silviodonato Sep 24, 2020

Choose a reason for hiding this comment

watson-ij Sep 25, 2020

Choose a reason for hiding this comment

silviodonato commented Sep 25, 2020

cmsbuild commented Sep 16, 2020 •

edited

cmsbuild commented Sep 22, 2020 •

edited

perrotta commented Sep 22, 2020 •

edited