Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles in GeneratorInterface part 2 #31488

Merged
merged 1 commit into from Sep 17, 2020
Merged

Clean BuildFiles in GeneratorInterface part 2 #31488

merged 1 commit into from Sep 17, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30866).

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

This one is nice because it breaks the dependency of GeneratorInterface on the PhysicsTools subsystem.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31488/18420

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

GeneratorInterface/AlpgenInterface
GeneratorInterface/CascadeInterface
GeneratorInterface/Core
GeneratorInterface/EvtGenInterface
GeneratorInterface/GenFilters
GeneratorInterface/LHEInterface
GeneratorInterface/PhotosInterface
GeneratorInterface/PomwigInterface
GeneratorInterface/TauolaInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Sep 17, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 01baa15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2354fb/9397/summary.html
CMSSW: CMSSW_11_2_X_2020-09-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2354fb/9397/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620510
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2620482
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@agrohsje
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2020

+1

@cmsbuild cmsbuild merged commit 568a8c4 into cms-sw:master Sep 17, 2020
@guitargeek guitargeek deleted the deps_GeneratorInterface_2 branch September 17, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants