Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in detecting cmssw environment in cmsShow script for patch releases #3149

Merged
merged 1 commit into from Apr 2, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Apr 2, 2014

cmsShow script presumed that the path of the script itself matches $CMSSW_RELEASE_BASE,
In some cases this is not true. This change simplifies check for cmssw environment and works for main and patch releases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_5_3_X.

Fix in detecting cmssw environment in cmsShow script for patch releases

It involves the following packages:

Fireworks/Core

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor

This is technical change for running cmsShow in patch releases. If no
objection then I will include it in 5.3.17.
Cheers,
--Shahzad
On 02/04/2014 02:53, cmsbuild wrote:

A new Pull Request was created by @alja https://github.com/alja
(Alja Mrak-Tadel) for CMSSW_5_3_X.

Fix in detecting cmssw environment in cmsShow script for patch releases

It involves the following packages:

Fireworks/Core

@Dr15Jones https://github.com/Dr15Jones, @cmsbuild
https://github.com/cmsbuild, @alja https://github.com/alja,
@nclopezo https://github.com/nclopezo, @Degano
https://github.com/degano, @ktf https://github.com/ktf can you
please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first
line of your reply.
You can reject by replying to this message having '-1' in the first
line of your reply.
@smuzaffar https://github.com/smuzaffar you are the release manager
for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#3149 (comment).

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Apr 2, 2014
Fix in detecting cmssw environment in cmsShow script for patch releases
@smuzaffar smuzaffar merged commit 47f7315 into cms-sw:CMSSW_5_3_X Apr 2, 2014
@alja alja deleted the scp53 branch April 15, 2014 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants