Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing HBHERecHit class for introducing out-of-time pileup correction #3150

Merged
merged 2 commits into from Apr 4, 2014

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Apr 2, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @igv4321 for CMSSW_7_1_X.

Igv4321/oot pileup prepare

It involves the following packages:

DataFormats/HcalRecHit

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2014

+1

for #3150 e3bc8f3

tested in CMSSW_7_1_X_2014-04-02-0200
(test area sign334) in a combination of pulls 3144 3150 3152 3154 3164 3184 3198
no regressions expected, none observed

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf ktf changed the title Igv4321/oot pileup prepare Preparing HBHERecHit class for introducing out-of-time pileup correction Apr 4, 2014
ktf added a commit that referenced this pull request Apr 4, 2014
Reco -- Preparing HBHERecHit class for introducing out-of-time pileup correction
@ktf ktf merged commit 510bb16 into cms-sw:CMSSW_7_1_X Apr 4, 2014
@ktf
Copy link
Contributor

ktf commented Apr 4, 2014

I renamed the pull request to:

Preparing HBHERecHit class for introducing out-of-time pileup correction

I hope that is fine. In general please try to reuse old pull request rather than opening a new one and always use an informative title.

@igv4321
Copy link
Contributor Author

igv4321 commented Apr 4, 2014

OK, thanks.

On 04/04/2014 02:52 AM, Giulio Eulisse wrote:

I renamed the pull request to:

Preparing HBHERecHit class for introducing out-of-time pileup correction

I hope that is fine. In general please try to reuse old pull request rather than opening a new one and always use an informative title.


Reply to this email directly or view it on GitHub #3150 (comment).

@igv4321 igv4321 deleted the igv4321/oot-pileup-prepare branch May 8, 2014 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants