Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes to GEM simulation #3153

Merged
merged 77 commits into from Apr 2, 2014
Merged

Bugfixes to GEM simulation #3153

merged 77 commits into from Apr 2, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 2, 2014

  • GE1/1 pad thickness is now 2 strips instead of 4
  • Validation module had a bug fixed + clean-up

Everything else is from merging and testing queued PRs for SLHC10

Cesare and others added 30 commits February 10, 2014 15:31
Merged CMSSW_6_2_X_SLHC from repository gem-sw
267b144
@geonmo
To get information of geometry using GEMGeometry.
6fc21ea
@geonmo
Merge branch 'CMSSW_6_2_X_SLHC' of https://github.com/cms-sw/cmssw in…
25adec9 
…to gem-sim-validation
@geonmo
Fix bug to get info about geometry.
eb48f89
@geonmo
Collect common function of GEMTrackMatch and make child classes.
996b897
@geonmo
Merge branch 'CMSSW_6_2_X_SLHC' of https://github.com/cms-sw/cmssw in…
d09bae6 
…to gem-sim-validation
@geonmo
Fix bug to access 72th chamber.
8081102
@geonmo
Code cleaning.
319fec7
@geonmo
Add try and catch for exception about GEMGeometry.
49fe019 
Separate bookHisto() and setGeometry().
@jshlee
Merge pull request #90 from cms-sw/CMSSW_6_2_X_SLHC
564dad0 
Cmssw 6 2 x slhc
@jshlee
Merge remote-tracking branch 'origin/cms-sw/CMSSW_6_2_X_SLHC' into CM…
f474c27 
…SSW_6_2_X_SLHC
@jshlee
Merge pull request #91 from cms-sw/CMSSW_6_2_X_SLHC
fe65259 
Cmssw 6 2 x slhc
@geonmo
bugfix about ChamberId.
b9067d6 
Add a feature to prevent crash if GEMGeometry is missing.
Code cleaning.
@jshlee
Merge pull request #92 from cms-sw/CMSSW_6_2_X_SLHC
50133bb 
Cmssw 6 2 x slhc
First implementation of TeV muon refits with GEMs
e883733
Merge remote-tracking branch 'gem-cmssw/CMSSW_6_2_X_SLHC' into from-C…
523e46a 
…MSSW_6_2_0_SLHC7
@jshlee
Merge pull request #93 from cms-sw/CMSSW_6_2_X_SLHC
6b5a571 
Cmssw 6 2 x slhc
@jshlee
Merge pull request #95 from cms-sw/CMSSW_6_2_X_SLHC
3a9e8ea 
Cmssw 6 2 x slhc
@jshlee
Merge pull request #96 from cms-sw/CMSSW_6_2_X_SLHC
94e51da 
Cmssw 6 2 x slhc
@jshlee
Merge pull request #98 from cms-sw/CMSSW_6_2_X_SLHC
fb5e114 
Cmssw 6 2 x slhc
@jshlee
Merge remote-tracking branch 'origin/cms-sw/CMSSW_6_2_X_SLHC' into CM…
37b13d6 
…SSW_6_2_X_SLHC
@jshlee
Merge pull request #99 from cms-sw/CMSSW_6_2_X_SLHC
1d5b173 
Cmssw 6 2 x slhc
@jshlee
Merge pull request #100 from cms-sw/CMSSW_6_2_X_SLHC
6480703 
Cmssw 6 2 x slhc
Merge pull request #103 from cms-sw/CMSSW_6_2_X_SLHC
a628e62 
Cmssw 6 2 x slhc
@jshlee
Merge pull request #104 from cms-sw/CMSSW_6_2_X_SLHC
5b4b65a 
Cmssw 6 2 x slhc
Merge pull request #105 from cms-sw/CMSSW_6_2_X_SLHC
72bbe60 
Cmssw 6 2 x slhc
Create rpcCustoms.py
b23167b
Add RPC customs
5913deb
@jshlee
Merge pull request #106 from cms-sw/CMSSW_6_2_X_SLHC
be802e8 
Cmssw 6 2 x slhc
@geonmo
Merge github.com:geonmo/cmssw into gem-sim-validation-for-gemsw
300dbde 
Conflicts:
	SLHCUpgradeSimulations/Configuration/python/combinedCustoms.py
	Validation/MuonGEMDigis/plugins/MuonGEMDigis.cc
	Validation/MuonGEMHits/plugins/MuonGEMHits.cc
ianna and others added 15 commits April 1, 2014 15:17
@ianna
Increase inner radius to avoid overlap with GE21.
abe1b86
@geonmo
Merge branch 'gem-sim-validation-for-gemsw' of github.com:geonmo/cmss…
6bbe969 
…w into from-CMSSW_6_2_0_SLHC9
@geonmo
Roll back to use genvalid.
8acd708
@geonmo
Remove typo.
4c1ec2e
Merged bugfix-gem-validation from repository dildick
81e3436
@geonmo
use genHarvesting for harvesting step.
add2c77
Merged gem-sim-validation-for-gemsw from repository geonmo
154d3c5 
Conflicts:
	SLHCUpgradeSimulations/Configuration/python/combinedCustoms.py
revert combinedCustoms
ebd7a4a
revert combinedCustoms
80394f1
Merged refs/pull/3137/head from repository cms-sw
2bd9348
Merged refs/pull/3136/head from repository cms-sw
0c73f26
Merged bugfix-gem-validation from repository dildick
0901573
2-strip pad for GE11
c22735f
update geometry analyzerÃ
15836fc
Merge pull request #24 from dildick/from-CMSSW_6_2_X_SLHC_2014-04-01-…
891edd1 
…1400

From cmssw 6 2 x slhc 2014 04 01 1400
@dildick dildick mentioned this pull request Apr 2, 2014
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Bugfixes to GEM simulation

It involves the following packages:

Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/HcalCommonData
Geometry/MuonCommonData
RecoMuon/GlobalTrackingTools
RecoMuon/TransientTrackingRecHit
SLHCUpgradeSimulations/Configuration
Validation/MuonGEMDigis
Validation/MuonGEMHits

The following packages do not have a category, yet:

Validation/MuonGEMDigis
Validation/MuonGEMHits

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

merge

Tested along with #3151 observing only the known errors.

@andersonjacob andersonjacob mentioned this pull request Apr 2, 2014
Merged
cmsbuild added a commit that referenced this pull request Apr 2, 2014
@cmsbuild
Merge pull request #3153 from dildick/bugfix-gem-validation
619b8a3 
Bugfixes to GEM simulation
@cmsbuild cmsbuild merged commit 619b8a3 into cms-sw:CMSSW_6_2_X_SLHC Apr 2, 2014
@dildick dildick deleted the bugfix-gem-validation branch April 2, 2014 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending geometry-pending new-package-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending
Projects
None yet
Milestone
Next CMSSW_6_2_X_SLHC
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dildick @cmsbuild @andersonjacob @geonmo @jshlee @pietverwilligen @ianna