Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean BuildFiles in Reco #31533

Merged
merged 1 commit into from Sep 24, 2020
Merged

Clean BuildFiles in Reco #31533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion PhysicsTools/IsolationAlgos/BuildFile.xml
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@
<use name="FWCore/PluginManager"/>
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/RecoCandidate"/>
<use name="FWCore/MessageLogger"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is included in e.g. plugins/CandIsoDepositProducer.cc and PhysicsTools/IsolationAlgos/plugins does not have FWCore/MessageLogger.
Shouldn't it be added there?

I vaguely recall that a similar case occurred before; I thought that this was taken care of already in the script.
(one example below in RecoTracker/FinalTrackSelectors/ vs plugins/ shows that this is handled in some way)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! No, the script doesn't consider this because I don't think we came to any clear conclusion what to do in these cases. I though if it still compiles it's fine. But okay, I will always add the removed dependency in plugins if necessary from now.

I handled the case in RecoTracker/FinalTrackSelectors manually, as this was mentioned in a comment by @davidlange6 in another commit.

<export>
<lib name="1"/>
</export>
1 change: 1 addition & 0 deletions PhysicsTools/IsolationAlgos/plugins/BuildFile.xml
View file
Open in desktop
Expand Up @@ -6,5 +6,6 @@
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/TauReco"/>
<use name="DataFormats/TrackReco"/>
<use name="FWCore/MessageLogger"/>
<use name="PhysicsTools/IsolationAlgos"/>
</library>
1 change: 1 addition & 0 deletions PhysicsTools/PatAlgos/BuildFile.xml
View file
Open in desktop
@@ -1,3 +1,4 @@
<use name="CommonTools/CandAlgos"/>
<use name="CommonTools/MVAUtils"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Common"/>
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/PatAlgos/plugins/BuildFile.xml
View file
Open in desktop
Expand Up @@ -20,7 +20,6 @@
<use name="CondFormats/JetMETObjects"/>
<use name="CondFormats/HcalObjects"/>
<use name="CondFormats/DataRecord"/>
<use name="CommonTools/CandAlgos"/>
<use name="CommonTools/Egamma"/>
<use name="CommonTools/MVAUtils"/>
<use name="JetMETCorrections/Objects"/>
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/PatAlgos/test/BuildFile.xml
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
<library name="PhysicsToolsPatAlgos_testAnalyzers" file="private/*.cc">
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="PhysicsTools/PatUtils"/>
<use name="DataFormats/PatCandidates"/>
<use name="root"/>
<flags EDM_PLUGIN="1"/>
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/PatUtils/BuildFile.xml
View file
Open in desktop
Expand Up @@ -24,7 +24,6 @@
<use name="JetMETCorrections/Modules"/>
<use name="JetMETCorrections/Objects"/>
<use name="JetMETCorrections/Type1MET"/>
<use name="PhysicsTools/SelectorUtils"/>
<use name="TrackingTools/TrajectoryState"/>
<use name="root"/>
<use name="rootmlp"/>
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/TagAndProbe/plugins/BuildFile.xml
View file
Open in desktop
Expand Up @@ -12,7 +12,6 @@
<use name="DataFormats/Math"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/EgammaCandidates"/>
<use name="RecoEgamma/EgammaTools"/>
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Common"/>
Expand Down
1 change: 0 additions & 1 deletion PhysicsTools/Utilities/BuildFile.xml
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
<use name="FWCore/Utilities"/>
<use name="FWCore/Common"/>
<use name="SimDataFormats/PileupSummaryInfo"/>
<use name="PhysicsTools/SelectorUtils"/>
<use name="roofit"/>
<use name="rootcore"/>
<use name="root"/>
Expand Down
1 change: 0 additions & 1 deletion RecoLocalMuon/CSCEfficiency/BuildFile.xml
View file
Open in desktop
@@ -1,7 +1,6 @@
<use name="DataFormats/CSCDigi"/>
<use name="DataFormats/CSCRecHit"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/MuonDetId"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/Utilities"/>
Expand Down
1 change: 0 additions & 1 deletion RecoLuminosity/LumiProducer/test/BuildFile.xml
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
<use name="FWCore/ParameterSet"/>
<use name="DataFormats/VertexReco"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="DataFormats/SiPixelDetId"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="HLTrigger/HLTcore"/>
<use name="CondFormats/RunInfo"/>
Expand Down
2 changes: 0 additions & 2 deletions RecoMuon/MuonIdentification/test/BuildFile.xml
View file
Open in desktop
Expand Up @@ -2,10 +2,8 @@
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/MuonReco"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/ParameterSet"/>
<use name="RecoMuon/MuonIdentification"/>
<use name="DataFormats/RecoCandidate"/>
<use name="CommonTools/UtilAlgos"/>
<use name="boost"/>
<use name="rootgraphics"/>
Expand Down
1 change: 0 additions & 1 deletion RecoTracker/FinalTrackSelectors/BuildFile.xml
View file
Open in desktop
@@ -1,5 +1,4 @@
<use name="ofast-flag"/>
<use name="DataFormats/GeometryCommonDetAlgo"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/VertexReco"/>
<use name="FWCore/Framework"/>
Expand Down
1 change: 1 addition & 0 deletions RecoTracker/FinalTrackSelectors/plugins/BuildFile.xml
View file
Open in desktop
@@ -1,6 +1,7 @@
<use name="ofast-flag"/>
<use name="RecoTracker/FinalTrackSelectors"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/GeometryCommonDetAlgo"/>
<use name="DataFormats/Math"/>
<use name="DataFormats/TrackerCommon"/>
<use name="DataFormats/SiPixelDetId"/>
Expand Down
1 change: 0 additions & 1 deletion RecoTracker/MeasurementDet/BuildFile.xml
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@
<use name="DataFormats/SiPixelCluster"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="Geometry/TrackerGeometryBuilder"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in RecoTracker/MeasurementDet/plugins, but not present in the BuildFile there already.

<use name="TrackingTools/TrajectoryState"/>
<use name="RecoTracker/TkDetLayers"/>
<use name="CondFormats/SiStripObjects"/>
Expand Down
1 change: 1 addition & 0 deletions RecoTracker/MeasurementDet/plugins/BuildFile.xml
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
<use name="CalibTracker/Records"/>
<use name="CondFormats/DataRecord"/>
<use name="CondFormats/SiPixelObjects"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="TrackingTools/KalmanUpdators"/>
<use name="RecoTracker/Record"/>
<use name="RecoTracker/TkDetLayers"/>
Expand Down
1 change: 0 additions & 1 deletion Validation/MuonME0Validation/BuildFile.xml
View file
Open in desktop
@@ -1,5 +1,4 @@
<use name="boost"/>
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/GEMDigi"/>
<use name="DataFormats/GEMRecHit"/>
<use name="DataFormats/Scalers"/>
Expand Down