Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 111X of L1-O2O fractional prescale propagation #31545

Merged
merged 9 commits into from Sep 30, 2020

Conversation

hjkwon260
Copy link
Contributor

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is backport of #30886. L1-O2O fractional prescale is planned to be tested in next MWGR and private global run.

One commit 6abb51c is added since edm::mpl is not present for 111X.

Ping @gekobs @panoskatsoulis @BenjaminRS @bundocka as well.

PR validation:

runTheMatrix test, code format check passed

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hjkwon260 (Hyejin Kwon) for CMSSW_11_1_X.

It involves the following packages:

CondCore/L1TPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/L1TObjects
CondTools/L1TriggerExt
L1Trigger/L1TGlobal
L1TriggerConfig/L1TConfigProducers

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6abb51c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fc3d/9518/summary.html
CMSSW: CMSSW_11_1_X_2020-09-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fc3d/9518/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2781012
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780961
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

Any objection from @cms-sw/alca-l2 @cms-sw/db-l2 @cms-sw/l1-l2 ?

@tlampen
Copy link
Contributor

tlampen commented Sep 25, 2020

+alca

@ggovi
Copy link
Contributor

ggovi commented Sep 25, 2020

The changes in this PR are introducing a the new class in replacement of an existing one; it looks like only the 'private' L1T workflow have been adapted for this replacement, while all of the consumer code ( HLT?) has not been touched. This is obviously ok until you don't need updates on the existing tags ( implemented with the old class ). What is the plan/intention for this?

@rekovic
Copy link
Contributor

rekovic commented Sep 27, 2020

+1

@rekovic
Copy link
Contributor

rekovic commented Sep 27, 2020

@ggovi Changes in the GlobalTrigger on which the Offline worflows would depend need changes (changes of ints to floats, etc). Work is started on this by the L1T GlobalTrigger experts.

@silviodonato
Copy link
Contributor

urgent
to be included for the MWGR

@ggovi
Copy link
Contributor

ggovi commented Sep 30, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 30, 2020

+1

@cmsbuild cmsbuild merged commit 831b292 into cms-sw:CMSSW_11_1_X Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants