New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 111X of L1-O2O fractional prescale propagation #31545
Backport to 111X of L1-O2O fractional prescale propagation #31545
Conversation
A new Pull Request was created by @hjkwon260 (Hyejin Kwon) for CMSSW_11_1_X. It involves the following packages: CondCore/L1TPlugins @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Any objection from @cms-sw/alca-l2 @cms-sw/db-l2 @cms-sw/l1-l2 ? |
+alca |
The changes in this PR are introducing a the new class in replacement of an existing one; it looks like only the 'private' L1T workflow have been adapted for this replacement, while all of the consumer code ( HLT?) has not been touched. This is obviously ok until you don't need updates on the existing tags ( implemented with the old class ). What is the plan/intention for this? |
+1 |
@ggovi Changes in the GlobalTrigger on which the Offline worflows would depend need changes (changes of ints to floats, etc). Work is started on this by the L1T GlobalTrigger experts. |
urgent |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is backport of #30886. L1-O2O fractional prescale is planned to be tested in next MWGR and private global run.
One commit 6abb51c is added since edm::mpl is not present for 111X.
Ping @gekobs @panoskatsoulis @BenjaminRS @bundocka as well.
PR validation:
runTheMatrix test, code format check passed