[Fireworks 11_2_X] Add necessary checks for valid hitMap handle in HGCal proxy builders

[alja]

PR description:

Add a check for valid hitmap handle

[cmsbuild]

@alja, CMSSW_11_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[alja]

@rovere
Please look. It may be you want to handle digit color differently if hitmap is not available.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31547/18556

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Fireworks/Calo/interface/FWHeatmapProxyBuilderTemplate.h modified in PR(s): Ensure HGCAL RecHit map is filled also without RECO #31536

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31547/18556/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31547/18556/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[lecriste]

I have restored the hitMap in #31536

[silviodonato]

please test with #31536

[alja]

@lecriste Thank you to follow up.
@rovere Please look #31536 to know the changes.

[lecriste]

@alja, @silviodonato, this PR is superseded by #31536 and can be closed - no need to be tested together in my opinion.

[alja]

@lecriste Is it possible map std::unordered_map<DetId, const HGCRecHit*>* hitmap is empty while trying to visualize reco::CaloCluster or reco::HGCalMultiCluster collections? If so, the two derived proxy builders (FWCaloClusterProxyBuilder and FWHGCalMultiClusterProxyBuilder) need the check for valid hitmap.

[lecriste]

@lecriste Is it possible map std::unordered_map<DetId, const HGCRecHit*>* hitmap is empty while trying to visualize reco::CaloCluster or reco::HGCalMultiCluster collections?

I don't know whether that could happen but I verified that #31536 does not crash also in such a case.

[alja]

@lecriste Yes, I see now. I will close this PR.