[HGCal] Add unit test for HGCal material budget plots

[apsallid]

PR description:

Include a unit test for HGCal material budget plots in order for reviewers to inspect the regularly updated/created geometries.

Running locally on lxplus the script according to time command took:

real 17m39.955s
user 15m21.406s
sys 1m41.116s

The single_neutrino_cfg.py, which is used identically by the Tracker, is run in the glimpse of an eye, so instead of mixing this unit test with the Tracker one (essentially messing it up) I think it is better to create a new one.

I hope the running time isn’t an issue.

@vargasa : Thanks a lot for the suggestion and the help.

PR validation:

Will check if the unit test runs fine in this PR. Locally, there wasn't any issue.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

@rovere @felicepantaleo @ebrondol @vargasa

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31565/18593

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @lecriste, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9538/console Started: 2020/09/24 13:38

[cmsbuild]

+1
Tested at: 568b886
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9538/summary.html
CMSSW: CMSSW_11_2_X_2020-09-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[apsallid]

Could you please tell me how you add the last line in the test page here
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9538/summary.html
that gives the link to the material budget plot?

For the moment I am just changing the name in the address. It looks ok:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9538/materialBudgetHGCalPlots/

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9538/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2539438
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2539415
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[vargasa]

that gives the link to the material budget plot?

As I understand, it won't be shown until the new BuildFile.xml gets integrated. I.e it will be shown from the next PRs. You can check with @smuzaffar if that's the case

For the moment I am just changing the name in the address. It looks ok:

The test works great!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31565/18658

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #31565 was updated. @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please check and sign again.

[apsallid]

@cvuosalo @rovere This is the most basic test that can be performed that proves if scripts are running normally. It takes 4 minutes.

real 4m13.209s
user 2m47.140s
sys 0m40.569s

If 4 minutes is not acceptable then there is no reason to keep this unit test. I can add it in our usual
RelVal campaign validation workflow, but this will prove if it works in a specific prerelease and not the specific IB.

[cvuosalo]

I suppose four minutes for the test is acceptable.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-28-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9634/console Started: 2020/09/29 00:49

[cmsbuild]

+1
Tested at: 846bb2a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9634/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c092/9634/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2539438
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2539409
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

+1

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1