Conclude removal of type specification from RecoBTag #31568

perrotta · 2020-09-24T13:56:57Z

PR description:

A couple of parameters were forgotten in #31538, when the type specification was removed from cloned/modified configs
This is completed here (together with some "innocent" realignment of the config parameters listed for pfDeepCSVJetTags)

cmsbuild · 2020-09-24T13:57:22Z

The code-checks are being triggered in jenkins.

perrotta · 2020-09-24T14:09:49Z

please test

cmsbuild · 2020-09-24T14:20:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31568/18598

This PR adds an extra 12KB to repository

cmsbuild · 2020-09-24T14:20:37Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9547/console Started: 2020/09/24 16:21

cmsbuild · 2020-09-24T14:20:38Z

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoBTag/Combined

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @riga, @JyothsnaKomaragiri, @ferencek, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-09-24T17:15:51Z

-1

Tested at: e67ef9b

CMSSW: CMSSW_11_2_X_2020-09-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

xrd commands are deprecated, use xrdfs instead #31553 @smuzaffar: xrd commands are deprecated, use xrdfs instead
drop type specs in RecoBTag #31538 @jeongeun: drop type specs in RecoBTag
Remove setConsumes() from ESConsumesCollector #31556 @makortel: Remove setConsumes() from ESConsumesCollector
add back incorrectly removed dependencies to DataFormats/ParticleFlowReco #31534 @davidlange6: add back incorrectly removed dependencies to DataFormats/ParticleFlowReco
Ensure HGCAL RecHit map is filled also without RECO #31536 @lecriste: Ensure HGCAL RecHit map is filled also without RECO
Run4-hgx261 Bug fix for the v14 geometry of HGCal #31516 @bsunanda: Run4-hgx261 Bug fix for the v14 geometry of HGCal
MTD: update ETLDetId to accomodate larger module numbers #31511 @fabiocos: MTD: update ETLDetId to accomodate larger module numbers

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test GeometryMTDGeometryBuilderTestDriver had ERRORS
---> test GeometryMTDNumberingBuilderTestDriver had ERRORS
---> test GeometryMTDCommonDataTestDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

xrd commands are deprecated, use xrdfs instead #31553 @smuzaffar: xrd commands are deprecated, use xrdfs instead
drop type specs in RecoBTag #31538 @jeongeun: drop type specs in RecoBTag
Remove setConsumes() from ESConsumesCollector #31556 @makortel: Remove setConsumes() from ESConsumesCollector
add back incorrectly removed dependencies to DataFormats/ParticleFlowReco #31534 @davidlange6: add back incorrectly removed dependencies to DataFormats/ParticleFlowReco
Ensure HGCAL RecHit map is filled also without RECO #31536 @lecriste: Ensure HGCAL RecHit map is filled also without RECO
Run4-hgx261 Bug fix for the v14 geometry of HGCal #31516 @bsunanda: Run4-hgx261 Bug fix for the v14 geometry of HGCal
MTD: update ETLDetId to accomodate larger module numbers #31511 @fabiocos: MTD: update ETLDetId to accomodate larger module numbers

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/git-merge-result

cmsbuild · 2020-09-24T17:15:53Z

Comparison job queued.

cmsbuild · 2020-09-24T18:41:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9547/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 593 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1920
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2537496
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-09-24T19:00:48Z

please test

cmsbuild · 2020-09-24T19:01:10Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9557/console Started: 2020/09/24 21:03

cmsbuild · 2020-09-24T20:11:50Z

+1
Tested at: e67ef9b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9557/summary.html
CMSSW: CMSSW_11_2_X_2020-09-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-24T20:11:53Z

Comparison job queued.

cmsbuild · 2020-09-24T21:39:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3baae/9557/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-09-25T05:15:43Z

+1

Technical
Jenkins tests pass

cmsbuild · 2020-09-25T05:16:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-09-25T07:26:36Z

+1

Continue removing type specification

e67ef9b

cmsbuild added this to the CMSSW_11_2_X milestone Sep 24, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 24, 2020

perrotta mentioned this pull request Sep 24, 2020

drop type specs in RecoBTag #31538

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 24, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 24, 2020

cmsbuild added tests-rejected and removed tests-started labels Sep 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 24, 2020

cmsbuild removed the comparison-available label Sep 24, 2020

cmsbuild added comparison-pending and removed tests-rejected labels Sep 24, 2020

cmsbuild added tests-pending tests-started and removed tests-pending labels Sep 24, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 24, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 25, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 25, 2020

cmsbuild merged commit a9bb630 into cms-sw:master Sep 25, 2020

perrotta deleted the additionToPr31358 branch September 25, 2020 07:38

cmsbuild mentioned this pull request Sep 25, 2020

Absorb CSCCommonTrigger into CSCTriggerPrimitives #31549

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conclude removal of type specification from RecoBTag #31568

Conclude removal of type specification from RecoBTag #31568

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 •

edited

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 •

edited

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

perrotta commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

silviodonato commented Sep 25, 2020

Conclude removal of type specification from RecoBTag #31568

Conclude removal of type specification from RecoBTag #31568

Conversation

perrotta commented Sep 24, 2020

PR description:

cmsbuild commented Sep 24, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 • edited

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

perrotta commented Sep 24, 2020

cmsbuild commented Sep 24, 2020 • edited

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

cmsbuild commented Sep 24, 2020

perrotta commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

silviodonato commented Sep 25, 2020

cmsbuild commented Sep 24, 2020 •

edited

cmsbuild commented Sep 24, 2020 •

edited