Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting Herwig7.2 mpi settings to CMSSW_10_6_X #31613

Merged
merged 1 commit into from Sep 29, 2020

Conversation

SiewYan
Copy link
Contributor

@SiewYan SiewYan commented Sep 29, 2020

PR description:

backporting Herwig7 MPI settings for Herwig7.2 to CMSSW_10_6_X

1.) Rename of AlphaMZ to AlphaIn
2.) Remove redundant/obsolete settings in tune configs
3.) Added additional settings block that replicate the MPI model of Herwig7.1 in Herwig7.2, which is required for using the CH tunes.

PR validation:

echoing the result from master branch:

Tested by generating MB events locally with these settings. Validation and details of the changes were presented at the GEN meeting on 25th May 2020 (https://indico.cern.ch/event/916119/#3-ch3-with-herwig-72)

if this PR is a backport please specify the original PR and why you need to backport that PR:

#30196

@SiewYan
Copy link
Contributor Author

SiewYan commented Sep 29, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SiewYan (SiewYan) for CMSSW_10_6_X.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: e8c895b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7953/9644/summary.html
CMSSW: CMSSW_10_6_X_2020-09-29-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato silviodonato changed the title backporting H7p2 mpi settings to CMSSW_10_6_X backporting Herwig7.2 mpi settings to CMSSW_10_6_X Sep 29, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7953/9644/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214655
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214320
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@agrohsje
Copy link

+generators

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c921c44 into cms-sw:CMSSW_10_6_X Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants