Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] ParticleNetAK4 jet tagger #31615

Merged
merged 3 commits into from Oct 7, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Sep 29, 2020

PR description:

Backport of #31570.
The addition of the ParticleNetAK4 discriminants to miniAOD is controlled by the run2_miniAOD_UL modifier in this backport.

Needs cms-data/RecoBTag-Combined#35.

FYI @camclean @alefisico

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/ONNXRuntime

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @rappoccio, @gouskos, @jdolen, @ahinzmann, @smoortga, @riga, @schoef, @emilbols, @mariadalfonso, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @peruzzim, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Sep 30, 2020

test parameters:

@qliphy
Copy link
Contributor

qliphy commented Sep 30, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoBTag-Combined#35

@cmsbuild
Copy link
Contributor

+1
Tested at: fb71408
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e2d87/9655/summary.html
CMSSW: CMSSW_10_6_X_2020-09-29-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e2d87/9655/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214655
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214320
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

test parameters

@silviodonato
Copy link
Contributor

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6288

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+1
Tested at: fb71408
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80a945/9709/summary.html
CMSSW: CMSSW_10_6_X_2020-10-02-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80a945/9709/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214655
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214319
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@jpata
Copy link
Contributor

jpata commented Oct 6, 2020

+reconstruction

  • backports the ParticleNetAK4 tagger to 106X for UL miniaod
  • needs Add ParticleNetAK4 cms-data/RecoBTag-Combined#35 to be merged first
  • tagger is enabled only for UL workflows using the appropriate modifier and shows up in the appropriate monitoring
  • no other unexpected reco modifications

@silviodonato
Copy link
Contributor

merge
@cms-sw/analysis-l2 please let us know if you have any comments

@cmsbuild cmsbuild merged commit 1ebac3a into cms-sw:CMSSW_10_6_X Oct 7, 2020
@santocch
Copy link

santocch commented Oct 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants