GEM uniform angular strip topology #31640

hyunyong · 2020-10-01T14:11:52Z

PR description:

Current GEM strip topology is trapezoidal strip topology
It is not uniform angle distributions
New GEM Strip topology has been added
Most functions are from CSC Radial Strip Topology
New XML files (v13) are created but they didn't add to any cfi files yet.

PR validation:

PR passed code-checks and code-format
GEM DPG approved
https://indico.cern.ch/event/959823/contributions/4034596/attachments/2114039/3556405/GEMStripTopo.pdf

@jshlee @watson-ij @bsunanda

cmsbuild · 2020-10-01T14:12:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-01T14:18:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31640/18725

This PR adds an extra 48KB to repository

cmsbuild · 2020-10-01T14:19:02Z

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

Fireworks/Geometry
Geometry/CommonTopologies
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
RecoLocalMuon/GEMRecHit
SimMuon/GEMDigitizer

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @alja, @kpedro88, @slava77, @jpata can you please review it and eventually sign? Thanks.
@alja, @makortel, @JanFSchulte, @jhgoh, @VinInn, @jshlee, @bellan, @watson-ij, @dildick, @ebrondol, @mtosi, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

dildick · 2020-10-01T14:33:46Z

@hyunyong Shouldn't the radial GEMStripTopology inherit from RadialStripTopology instead of StripTopology?

hyunyong · 2020-10-01T14:38:53Z

@hyunyong Shouldn't the radial GEMStripTopology inherit from RadialStripTopology instead of StripTopology?

@dildick GEM strip topology was based on the trapezoidal strip topology and some functions are not comparable with the radial strip topology.
I tried the radial strip topology but changed to the strip topology.

alja · 2020-10-01T17:03:07Z

+1

cmsbuild · 2020-10-01T17:03:32Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9690/console Started: 2020/10/01 19:04

kpedro88 · 2020-10-01T17:24:32Z

Geometry/CommonTopologies/interface/GEMStripTopology.h

@@ -0,0 +1,73 @@
+#ifndef _GEM_STRIP_TOPOLOGY_H_


use correct include guard format: subsystem_package_filename

kpedro88 · 2020-10-01T17:25:55Z

Geometry/CommonTopologies/interface/GEMStripTopology.h

+  float theCentreToIntersection;  // distance centre of detector face to intersection of edge strips (projected)
+  float thePhiOfOneEdge;          // local 'phi' of one edge of plane of strips (I choose it negative!)
+  float theYAxisOrientation;      // 1 means y axis going from smaller to larger side, -1 means opposite direction
+  float yCentre;  // Non-zero if offset in local y between midpoint of detector (strip plane) extent and local origin.


member variables need to have consistent naming scheme, i.e. theYCentre
(or even better, to correspond to base class, remove "the", start with lowercase, and end with underscore)

kpedro88 · 2020-10-01T17:26:18Z

Geometry/CommonTopologies/src/GEMStripTopology.cc

+  thePhiOfOneEdge = -(0.5 * theNumberOfStrips) * theAngularWidth * theYAxisOrientation;
+  yCentre = 0;
+#ifdef VERBOSE
+  cout << "Constructing GEMStripTopology with"


cout is not allowed, use MessageLogger (everywhere)

kpedro88 · 2020-10-01T17:27:51Z

Geometry/GEMGeometry/src/GEMEtaPartitionSpecs.cc

@@ -13,14 +13,17 @@ GEMEtaPartitionSpecs::GEMEtaPartitionSpecs(SubDetector rss, const std::string& n
    float r0 = h * (B + b) / (B - b);
    float striplength = h * 2;
    float strips = _p[3];
-    float pitch = (b + B) / strips;
+    float dphi = _p[5] * TMath::Pi() / 180.;


use https://github.com/cms-sw/cmssw/blob/master/DataFormats/Math/interface/angle_units.h to convert radians to degrees, avoid TMath

kpedro88 · 2020-10-01T17:28:37Z

Geometry/GEMGeometry/src/GEMEtaPartitionSpecs.cc

    int nstrip = static_cast<int>(strips);
-    _top = new TrapezoidalStripTopology(nstrip, pitch, striplength, r0);
+    _top = new GEMStripTopology(nstrip, phiPitch, striplength, r0);


possibly outside the scope of this PR, but it would be better to use smart pointers

I've fixed this PR as your comments, but I can't understand how to use smart pointers for this.

cmsbuild · 2020-10-01T18:16:33Z

-1

Tested at: 597c95a

CMSSW: CMSSW_11_2_X_2020-10-01-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ed7f4/9690/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
23434.999 step3

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step3_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

cmsbuild · 2020-10-01T18:16:35Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-11-05T21:20:24Z

Pull request #31640 was updated. @perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @alja, @kpedro88, @slava77, @jpata can you please check and sign again.

cvuosalo · 2020-11-05T21:28:41Z

@cmsbuild please test

cmsbuild · 2020-11-05T21:29:08Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-05-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10539/console Started: 2020/11/05 22:31

cmsbuild · 2020-11-05T22:51:28Z

+1
Tested at: 21982f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ed7f4/10539/summary.html
CMSSW: CMSSW_11_2_X_2020-11-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-05T22:51:30Z

Comparison job queued.

cmsbuild · 2020-11-06T00:09:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ed7f4/10539/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 198 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544144
DQMHistoTests: Total failures: 1081
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543041
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-11-06T20:17:32Z

+1

perrotta · 2020-11-07T09:14:50Z

RecoLocalMuon/GEMRecHit/test/TestGEMRecHitAnalyzer.cc

@@ -72,8 +72,7 @@
 #include <DataFormats/CSCRecHit/interface/CSCSegmentCollection.h>
 #include <Geometry/CommonDetUnit/interface/GeomDet.h>
 #include <Geometry/Records/interface/MuonGeometryRecord.h>
-#include <Geometry/CommonTopologies/interface/RectangularStripTopology.h>
-#include <Geometry/CommonTopologies/interface/TrapezoidalStripTopology.h>
+#include <Geometry/CommonTopologies/interface/GEMStripTopology.h>


The replacement is in line with the overall migration performed in this PR,
On the other hand, this include doesn't even seem to be needed at all in this test analyzer (as they were not need also the previous two which are being replaced).
Not really an issue, anyhow...

perrotta · 2020-11-07T09:16:35Z

+1

Changes are in the geometry part: they only propagate to reco in a test analyzer (in which the corresponding include wasn't even needed since the beginning, by the way...)

civanch · 2020-11-11T10:14:00Z

+1

kpedro88 · 2020-11-11T13:58:08Z

+upgrade

silviodonato · 2020-11-16T16:13:15Z

merge

cmsbuild added this to the CMSSW_11_2_X milestone Oct 1, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending visualization-pending labels Oct 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 1, 2020

cmsbuild added visualization-approved and removed visualization-pending labels Oct 1, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2020

kpedro88 reviewed Oct 1, 2020

View reviewed changes

cmsbuild added comparison-notrun and removed comparison-pending tests-started labels Oct 1, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 5, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 6, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Nov 6, 2020

perrotta reviewed Nov 7, 2020

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 7, 2020

cmsbuild added simulation-approved and removed simulation-pending labels Nov 11, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Nov 11, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 16, 2020

cmsbuild merged commit f374bf1 into cms-sw:master Nov 16, 2020

cmsbuild mentioned this pull request Nov 16, 2020

PPS nanoAOD #31531

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEM uniform angular strip topology #31640

GEM uniform angular strip topology #31640

hyunyong commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

dildick commented Oct 1, 2020

hyunyong commented Oct 1, 2020 •

edited

alja commented Oct 1, 2020

cmsbuild commented Oct 1, 2020 •

edited

kpedro88 Oct 1, 2020

kpedro88 Oct 1, 2020

kpedro88 Oct 1, 2020

kpedro88 Oct 1, 2020

kpedro88 Oct 1, 2020

hyunyong Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Nov 5, 2020

cvuosalo commented Nov 5, 2020

cmsbuild commented Nov 5, 2020 •

edited

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 6, 2020

cvuosalo commented Nov 6, 2020

perrotta Nov 7, 2020

perrotta commented Nov 7, 2020

civanch commented Nov 11, 2020

kpedro88 commented Nov 11, 2020

silviodonato commented Nov 16, 2020

GEM uniform angular strip topology #31640

GEM uniform angular strip topology #31640

Conversation

hyunyong commented Oct 1, 2020

PR description:

PR validation:

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

dildick commented Oct 1, 2020

hyunyong commented Oct 1, 2020 • edited

alja commented Oct 1, 2020

cmsbuild commented Oct 1, 2020 • edited

kpedro88 Oct 1, 2020

Choose a reason for hiding this comment

kpedro88 Oct 1, 2020

Choose a reason for hiding this comment

kpedro88 Oct 1, 2020

Choose a reason for hiding this comment

kpedro88 Oct 1, 2020

Choose a reason for hiding this comment

kpedro88 Oct 1, 2020

Choose a reason for hiding this comment

hyunyong Oct 1, 2020

Choose a reason for hiding this comment

cmsbuild commented Oct 1, 2020

cmsbuild commented Oct 1, 2020

cmsbuild commented Nov 5, 2020

cvuosalo commented Nov 5, 2020

cmsbuild commented Nov 5, 2020 • edited

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 6, 2020

cvuosalo commented Nov 6, 2020

perrotta Nov 7, 2020

Choose a reason for hiding this comment

perrotta commented Nov 7, 2020

civanch commented Nov 11, 2020

kpedro88 commented Nov 11, 2020

silviodonato commented Nov 16, 2020

hyunyong commented Oct 1, 2020 •

edited

cmsbuild commented Oct 1, 2020 •

edited

cmsbuild commented Nov 5, 2020 •

edited