Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py #3165

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Apr 2, 2014

Same as #3164. Bugfix for the problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/btag/1070.html. The bug originally sneaked in with #1363.

Note that this PR has zero impact on the standard reconstruction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_0_X.

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py

It involves the following packages:

RecoBTag/PerformanceDB

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2014

+1

for #3165 438524d
tested in CMSSW_7_0_X_2014-04-22-0200
(test area sign704a in a combination of pulls 3165 3254 3273 3394)
including extended tests in few-K particle gun samples, few-hundred dijet, and ttbar with PU.
No regressions observed in monitored RECO quantities,
no differences in all harvested DQM plots for the extended tests (timing module jitter ignored).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Apr 23, 2014
…x_from-CMSSW_7_0_2

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py
@davidlange6 davidlange6 merged commit 2182620 into cms-sw:CMSSW_7_0_X Apr 23, 2014
@ferencek ferencek deleted the RecoBTagPerformanceDB-Bugfix_from-CMSSW_7_0_2 branch April 23, 2014 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants