Logging service for Condition Workflows

[ggovi]

PR description:

We are adding a new service to provide recollection of log messages, with the aim to store them in the database, related to the condition data stored in the same context.

The target and main use case for this implementation are the workflows providing the lumi-based conditions for HLT.

PR validation:

A dedicate unit tests validates the base Logger. Two integration tests are exercising the use case with an Oracle db destination.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31667/18787

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31667/18787/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31667/18787/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[ggovi]

Wondering how to avoid to fix this type of issues AFTER the PR submission. Running scram build code-format before the first submission seems to be not the way...

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31667/18788

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/CondDB
CondCore/DBOutputService
CondCore/Utilities

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-05-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9729/console Started: 2020/10/05 15:57

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31667/18974

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #31667 was updated. @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please check and sign again.

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-11-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9878/console Started: 2020/10/12 09:31

[cmsbuild]

+1
Tested at: 142c9d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f86cb/9878/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f86cb/9878/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542196
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[ggovi]

+1

[yuanchao]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1