Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py #3168

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Apr 2, 2014

Same as #3164. Bugfix for the problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/btag/1070.html. The bug originally sneaked in with #1364.

In addition, could #2503 be reopened and merged? Also note that this PR and #2503 have zero impact on the standard reconstruction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_5_3_X.

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py

It involves the following packages:

RecoBTag/PerformanceDB

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 3, 2014

about reopening: I think you, as the original submitter, should be able to reopen

@ferencek
Copy link
Contributor Author

ferencek commented Apr 3, 2014

It appears it is not possible to reopen closed PR's or at least I can't do it. Should I simply create a new PR?

Note that for the 5_3_X branch it would be nice to have #2503 since the packages it removes are no longer maintained on the CMSSW tree. Given that there are still some developments ongoing on the 5_3_X branch, it would be better not to have to manually remove these packages and then replace them with versions from the cms-btv-pog organization.

@slava77
Copy link
Contributor

slava77 commented May 9, 2014

+1

for #3168 d1d1527
tested in CMSSW_5_3_X_2014-05-08-1400 (test area sign5317a in a combination of
pulls 3168 3222 3223 3393 3672 3749)
No regressions observed

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

davidlange6 added a commit that referenced this pull request May 9, 2014
…x_from-CMSSW_5_3_17

Fixed the contents of RecoBTag/PerformanceDB/python/measure/Pool_btagMistagWinter13.py
@davidlange6 davidlange6 merged commit f64bcec into cms-sw:CMSSW_5_3_X May 9, 2014
@ferencek ferencek deleted the RecoBTagPerformanceDB-Bugfix_from-CMSSW_5_3_17 branch May 9, 2014 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants