Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubtractionSolid Vs UnionSolid For Muon Barrel #31683

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Oct 6, 2020

PR description:

This PR has been triggered by what @ianna wrote in the PRs #31520 and #31576. The Subtraction Solids have been replaced by Union Solids inside the Muon Barrel (MB). The same job, for ME, will be performed in a next PR.
This PR is not related to DD4hep migration.

PR validation:

  1. validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
    The attached picture shows, after this PR, no Muon overlaps.

  2. validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
    Muon's volumes are not present in the overlaps.out file.

  3. validation by runTheMatrix.py -l 25202.1 :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Oct 6 09:14:40 2020-date Tue Oct 6 08:53:00 2020;
exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

Schermata 2020-10-06 alle 09 17 48

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31683/18821

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @fabiocos, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 6, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

+1
Tested at: 3c3ed52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fdbd0/9760/summary.html
CMSSW: CMSSW_11_2_X_2020-10-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fdbd0/9760/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 6, 2020

+upgrade

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 7, 2020

It may be a while before this change can be get into a new Global Tag.

@qliphy
Copy link
Contributor

qliphy commented Oct 8, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants