-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubtractionSolid Vs UnionSolid For Muon Barrel #31683
SubtractionSolid Vs UnionSolid For Muon Barrel #31683
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31683/18821
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
It may be a while before this change can be get into a new Global Tag. |
+1 |
PR description:
This PR has been triggered by what @ianna wrote in the PRs #31520 and #31576. The Subtraction Solids have been replaced by Union Solids inside the Muon Barrel (MB). The same job, for ME, will be performed in a next PR.
This PR is not related to DD4hep migration.
PR validation:
validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
The attached picture shows, after this PR, no Muon overlaps.
validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
Muon's volumes are not present in the overlaps.out file.
validation by runTheMatrix.py -l 25202.1 :
25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Oct 6 09:14:40 2020-date Tue Oct 6 08:53:00 2020;
exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special