Adapt EgammaHadTower and ElectronHcalHelper classes to use ESGetToken

[guitargeek]

PR description:

Some of the RecoEgamma plugins are not trivial to migrate to the ES tokens because the EventSetup gets passed through many layers of helper-class abstractions. Turning the former EgammaHadTower helper class (that took the EventSetup as a constructor argument) to free functions that take the ES products directly would remove one of these abstraction layers, making it simpler to migrate some of electron and photon reconstruction plugins.

Another helper class that also makes use of EgammaHadTower is the ElectronHcalHelper, which is now using the ESGetTokens.

PR validation:

Local matrix tests pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31700/18861

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers
RecoParticleFlow/PFProducer

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @folguera, @jainshilpi, @afiqaize, @rovere, @lgray, @calderona, @HuguesBrun, @Fedespring, @lecriste, @hatakeyamak, @cbernet, @cericeci, @varuns23, @seemasharmafnal, @sobhatta this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-07-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9798/console Started: 2020/10/08 07:49

[cmsbuild]

+1
Tested at: 0d9d2e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97a156/9798/summary.html
CMSSW: CMSSW_11_2_X_2020-10-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97a156/9798/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542196
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

+1
Tested at: 6828a9f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97a156/10129/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97a156/10129/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544100
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544077
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[slava77]

+1

for #31700 6828a9f

• technical; mostly in line with the PR title and description (more technical updates to use "type-less" [es]Consumes calls are included as well )
• jenkins tests pass

[Martin-Grunewald]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1