Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPS tags in Run 2 offline GTs for re-miniAOD [10_6_X] #31702

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of PR #31635. See the description of that PR for details. The GT diff is as follows:

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v28/106X_dataRun2_v29

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v26/106X_dataRun2_relval_v27

The obsolete record L1TMuonEndcapParamsRcd removed in PR #31635 is not removed here in order to minimize the changes made here.

PR validation:

See the description of PR #31635 for details. In addition, a technical test was performed: runTheMatrix.py -l limited,136.8642,136.72411 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #31635. The GTs in this PR are needed for the re-miniAOD of the Run 2 legacy dataset.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 136.8642,136.72411

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

+1
Tested at: dbee067
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11bb8d/9783/summary.html
CMSSW: CMSSW_10_6_X_2020-10-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11bb8d/9783/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-11bb8d/136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-11bb8d/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214655
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214316
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2020

+1

@cmsbuild cmsbuild merged commit 0b5129a into cms-sw:CMSSW_10_6_X Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants