[DD4hep] Introduce FilteredView nextChild #31711

ianna · 2020-10-08T10:18:38Z

This allows to dramatically improve performance by cutting the iteration over the rest of the tree

FilteredView nextChild() will stop iteration when a level set by a firstChild() is reached

  fview.firstChild();
  do {
    // do something here
   ...
   } while (fview.nextChild());

See DDFilteredView.firstChild.cppunit.cc unit test

@bsunanda, @fabiocos, @slomeo, @vargasa, @ghugo83 - FYI

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…ld is reached

cmsbuild · 2020-10-08T10:19:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-08T10:24:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31711/18885

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): Fix handling of XML paths (SpecPar) by DD4hep FilteredView #31677

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31711/18885/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31711/18885/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-08T11:15:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-08T11:20:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31711/18887

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): Fix handling of XML paths (SpecPar) by DD4hep FilteredView #31677

cmsbuild · 2020-10-08T11:22:22Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-10-08T13:17:31Z

please test

cmsbuild · 2020-10-08T13:17:56Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9806/console Started: 2020/10/08 15:18

cmsbuild · 2020-10-08T14:40:17Z

-1

Tested at: b9fc74d

CMSSW: CMSSW_11_2_X_2020-10-08-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d1163/9806/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetHGCalPlots had ERRORS

cmsbuild · 2020-10-08T14:40:19Z

Comparison job queued.

ianna · 2020-10-08T15:13:12Z

The unit test failure doesn't seem related to this PR:

===== Test "materialBudgetHGCalPlots" ====
+ geom=Extended2026D62
+ VGEO_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry
+ TEST_DIR=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ '[' -d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots ']'
+ mkdir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/single_neutrino_cfg.py nEvents=1
+ python /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Validation/Geometry/test/runP_HGCal_cfg.py geom=Extended2026D62 label=HGCal

---> test materialBudgetHGCalPlots had ERRORS

cmsbuild · 2020-10-08T16:07:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d1163/9806/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-10-08T18:38:40Z

Is there documentation explaining how to use the DDFilteredView methods like firstChild, nextSibling, goTo, level, and so on? It seems like they have subtle behavior that developers need to know to use them correctly.

cmsbuild · 2020-10-09T13:15:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d1163/9826/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542188
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

ianna · 2020-10-09T20:04:28Z

please test

cmsbuild · 2020-10-09T20:04:46Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-09-1500/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9843/console Started: 2020/10/09 22:05

cmsbuild · 2020-10-09T21:23:07Z

+1
Tested at: b9fc74d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d1163/9843/summary.html
CMSSW: CMSSW_11_2_X_2020-10-09-1500
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-09T21:23:10Z

Comparison job queued.

cmsbuild · 2020-10-09T22:48:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d1163/9843/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

ianna · 2020-10-10T05:12:52Z

+1

cmsbuild · 2020-10-10T05:13:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-10T07:15:49Z

+1

add nextChild that will stop iteration when a level set by a firstChi…

ce4ba1b

…ld is reached

cmsbuild added this to the CMSSW_11_2_X milestone Oct 8, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Oct 8, 2020

code format

b9fc74d

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2020

cmsbuild mentioned this pull request Oct 8, 2020

fix DDFilteredView::parameters() crashing with a pseudotrapezoid #31712

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 8, 2020

cmsbuild added tests-rejected and removed tests-started labels Oct 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 8, 2020

cmsbuild added tests-rejected and removed tests-started labels Oct 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 9, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Oct 9, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 9, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Oct 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2020

cmsbuild merged commit 18386fa into cms-sw:master Oct 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] Introduce FilteredView nextChild #31711

[DD4hep] Introduce FilteredView nextChild #31711

ianna commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

ianna commented Oct 8, 2020

cmsbuild commented Oct 8, 2020 •

edited

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

ianna commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cvuosalo commented Oct 8, 2020

cmsbuild commented Oct 9, 2020

ianna commented Oct 9, 2020

cmsbuild commented Oct 9, 2020 •

edited

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

ianna commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

silviodonato commented Oct 10, 2020

[DD4hep] Introduce FilteredView nextChild #31711

[DD4hep] Introduce FilteredView nextChild #31711

Conversation

ianna commented Oct 8, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

ianna commented Oct 8, 2020

cmsbuild commented Oct 8, 2020 • edited

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

ianna commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cvuosalo commented Oct 8, 2020

cmsbuild commented Oct 9, 2020

ianna commented Oct 9, 2020

cmsbuild commented Oct 9, 2020 • edited

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

ianna commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

silviodonato commented Oct 10, 2020

cmsbuild commented Oct 8, 2020 •

edited

cmsbuild commented Oct 9, 2020 •

edited