Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Add ParticleNetAK4 to JME custom NanoAOD. #31717

Merged
merged 2 commits into from Nov 11, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Oct 8, 2020

Backport of #31714.

PR description:

This PR adds the ParticleNetAK4 tagger scores to the JME custom NanoAOD. The tagger is added to both AK4 CHS and Puppi jets.

PR validation:

Tested NANO step on a UL17 ttbar sample w/ --customise PhysicsTools/NanoAOD/custom_jme_cff.PrepJMECustomNanoAOD_MC, and the tagger scores are correctly added.

FYI @camclean @alefisico

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test workflow 25202.15,10224.15,11024.15

those are JME nano

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+1
Tested at: 1b7fc06
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e80c5/9817/summary.html
CMSSW: CMSSW_10_6_X_2020-10-08-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e80c5/9817/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214663
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214328
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

please test
I solved I trivial conflict

@silviodonato
Copy link
Contributor

silviodonato commented Nov 9, 2020

abort
I see you are still working on #31714.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Jenkins tests are aborted.

@mariadalfonso
Copy link
Contributor

please test workflow 25202.15,10224.15,11024.15

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 11f44a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e80c5/10652/summary.html
CMSSW: CMSSW_10_6_X_2020-11-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e80c5/10652/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214708
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214373
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor

+xpog

changes inline with master
only JMEnano are updated

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 366badf into cms-sw:CMSSW_10_6_X Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants