Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary dependency on sigc++ #31732

Merged
merged 1 commit into from Oct 19, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The dependency on sigc++ library was not needed in these packages.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31732/18936

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/PhysicsToolsObjects
GeneratorInterface/LHEInterface
HLTrigger/Timer
SimG4Core/Physics
SimG4Core/Watcher
SimMuon/DTDigitizer

@SiewYan, @cmsbuild, @civanch, @yuanchao, @mkirsano, @fwyzard, @christopheralanwest, @mdhildreth, @Martin-Grunewald, @alberto-sanchez, @agrohsje, @tocheng, @tlampen, @ggovi, @pohsun, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mkirsano, @battibass, @makortel, @tocheng, @slomeo, @rovere, @Martin-Grunewald, @jhgoh, @alberto-sanchez, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

+1
Tested at: 18000d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-723383/9834/summary.html
CMSSW: CMSSW_11_2_X_2020-10-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-723383/9834/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-723383/9834/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-723383/9834/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542196
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@agrohsje
Copy link

agrohsje commented Oct 9, 2020

+1

@civanch
Copy link
Contributor

civanch commented Oct 10, 2020

+1

@Martin-Grunewald
Copy link
Contributor

+1

@yuanchao
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/db-l2

2 similar comments
@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/db-l2

@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/db-l2

@silviodonato
Copy link
Contributor

merge
@ggovi please let us know if you have any objections

@cmsbuild cmsbuild merged commit ac52e07 into cms-sw:master Oct 19, 2020
@Dr15Jones Dr15Jones deleted the sigcppDependency branch October 20, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants