drop type specs in RecoTauTag #31748

jeongeun · 2020-10-11T13:56:25Z

PR description:

Update the safer syntax for existing parameter :

drop type specifications where the original parameter exists.
move all parameter inside the clone

Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
(The previous PR were PR#31162,PR#31243,PR#31332, PR#31389, PR#31523, PR#31538)

In this PR, total 17 files changed.

RecoTauTag/Configuration : 4 files
RecoTauTag/HLTProducers : 2 files
RecoTauTag/RecoTau : 11 files

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

cmsbuild · 2020-10-11T13:56:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-11T14:03:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31748/18963

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py modified in PR(s): Add anti-electron tauID for phase2 #31470

cmsbuild · 2020-10-11T14:03:44Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/HLTProducers
RecoTauTag/RecoTau

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@riga this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-10-11T18:10:13Z

please test

cmsbuild · 2020-10-11T18:10:39Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-11-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9863/console Started: 2020/10/11 20:13

cmsbuild · 2020-10-11T19:34:02Z

+1
Tested at: 5620af1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8154e/9863/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-11T19:34:05Z

Comparison job queued.

perrotta · 2020-10-11T20:05:35Z

RecoTauTag/Configuration/python/HPSPFTaus_cff.py

@@ -423,11 +423,11 @@
    verbosity = 0


at line 422 there is also a forgotten

inputIDNameSuffix = cms.string("dR03"),

perrotta · 2020-10-11T20:28:14Z

RecoTauTag/Configuration/python/boostedHPSPFTaus_cff.py

@@ -23,11 +22,11 @@
 ca8PFJetsCHSprunedForBoostedTaus = boostedTaus2.ak4PFJets.clone(
    boostedTaus3.CMSBoostedTauSeedingParameters,
    #src = cms.InputTag('pfNoPileUpForBoostedTaus'),


even if commented out, you can remove type specification also here

perrotta · 2020-10-11T20:41:12Z

RecoTauTag/RecoTau/python/RecoTauPiZeroBuilderPlugins_cfi.py

@@ -68,7 +68,7 @@
 # and eta x phi size of strip increasing for low pT photons



plugin parameter in modStrips forgotten

perrotta · 2020-10-11T20:44:30Z

RecoTauTag/RecoTau/python/RecoTauPiZeroBuilderPlugins_cfi.py

@@ -68,7 +68,7 @@
 # and eta x phi size of strip increasing for low pT photons

 modStrips2 = strips.clone(


Also forgotten makeCombinatoricStrips at L84

cmsbuild · 2020-10-11T21:01:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8154e/9863/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-10-12T06:45:50Z

please test

cmsbuild · 2020-10-12T06:46:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-11-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9876/console Started: 2020/10/12 08:47

cmsbuild · 2020-10-12T08:06:49Z

+1
Tested at: 4facfa9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8154e/9876/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-12T08:06:51Z

Comparison job queued.

cmsbuild · 2020-10-12T09:32:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8154e/9876/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-10-12T10:05:31Z

+1

Type specification dropped from cloned and modified configs as planned
Jenkins tests pass and show no differences wrt baseline

Martin-Grunewald · 2020-10-12T15:59:56Z

+1

cmsbuild · 2020-10-12T16:00:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-12T18:46:07Z

+1

drop type specs in RecoTauTag

5620af1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 11, 2020

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 11, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 11, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 11, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2020

perrotta reviewed Oct 11, 2020

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Oct 11, 2020

drop type specs

4facfa9

cmsbuild removed code-checks-approved comparison-available tests-approved labels Oct 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 12, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 12, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Oct 12, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 12, 2020

cmsbuild merged commit f713e6a into cms-sw:master Oct 12, 2020

jeongeun mentioned this pull request Oct 14, 2020

drop type specs in RecoVertex RecoPixelVertexing #31784

Merged

jeongeun mentioned this pull request Oct 21, 2020

drop type specs in RecoHGCal #31881

Merged

jeongeun mentioned this pull request Nov 5, 2020

drop type specs in RecoHI {HiEgammaAlgos,HiJetAlgos,HiMuonAlgos} #32031

Merged

jeongeun mentioned this pull request Mar 2, 2021

drop type specification in RecoTauTag #33035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop type specs in RecoTauTag #31748

drop type specs in RecoTauTag #31748

jeongeun commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

perrotta commented Oct 11, 2020

cmsbuild commented Oct 11, 2020 •

edited

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

perrotta Oct 11, 2020

perrotta Oct 11, 2020

perrotta Oct 11, 2020

perrotta Oct 11, 2020

cmsbuild commented Oct 11, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 •

edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

Martin-Grunewald commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

silviodonato commented Oct 12, 2020

		@@ -68,7 +68,7 @@
		# and eta x phi size of strip increasing for low pT photons

		@@ -68,7 +68,7 @@
		# and eta x phi size of strip increasing for low pT photons

		modStrips2 = strips.clone(

drop type specs in RecoTauTag #31748

drop type specs in RecoTauTag #31748

Conversation

jeongeun commented Oct 11, 2020

PR description:

PR validation:

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

perrotta commented Oct 11, 2020

cmsbuild commented Oct 11, 2020 • edited

cmsbuild commented Oct 11, 2020

cmsbuild commented Oct 11, 2020

perrotta Oct 11, 2020

Choose a reason for hiding this comment

perrotta Oct 11, 2020

Choose a reason for hiding this comment

perrotta Oct 11, 2020

Choose a reason for hiding this comment

perrotta Oct 11, 2020

Choose a reason for hiding this comment

cmsbuild commented Oct 11, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 • edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

Martin-Grunewald commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

silviodonato commented Oct 12, 2020

cmsbuild commented Oct 11, 2020 •

edited

cmsbuild commented Oct 12, 2020 •

edited