Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Framework depencency from L1MuBMTrack #31750

Merged
merged 1 commit into from Oct 16, 2020
Merged

Removed Framework depencency from L1MuBMTrack #31750

merged 1 commit into from Oct 16, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The function triggerScale did not actually use the EventSetup nor does any code actually call the function.

This fixes the code-violation of a DataFormats class depending upon FWCore/Framework.

PR validation:

The code compiles.

@Dr15Jones
Removed Framework depencency from L1MuBMTrack
25fb3c5 
The function triggerScale did not actually use the EventSetup nor
does any code actually call the function.
@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Oct 11, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

@davidlange6 FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31750/18968

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/L1TMuon

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@rovere, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 25fb3c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287b23/9866/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287b23/9866/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/l1-l2

1 similar comment
@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/l1-l2

@silviodonato
Copy link
Contributor

merge
@cms-sw/l1-l2

@cmsbuild cmsbuild merged commit 24d5363 into cms-sw:master Oct 16, 2020
@Dr15Jones Dr15Jones deleted the fixL1MuBMTrack branch October 20, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @silviodonato