New ETL Geometry Validation #31769
New ETL Geometry Validation #31769
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31769/19011
|
|
A new Pull Request was created by @gsorrentino18 (Giulia Sorrentino) for master. It involves the following packages: Validation/MtdValidation @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: 1ed8050 CMSSW: CMSSW_11_2_X_2020-10-13-1100 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31769/19142
|
|
Pull request #31769 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
|
@gsorrentino18 could you please summarize the updates and the result of checks? |
I checked the *D1 histograms to be sure that they are all correctly filled, and that for D49 the distributions look as before, except for a change in name. I also adjust the range of the hit Z position histograms in order to have the same range of the previous distributions and to exactly compare them in D49 scenario. The PR is now ready for test. |
|
unhold |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR modifies the ETL plugins in order to validate the new ETL-2 disks geometry, following PR #31765 prepared by @fabiocos. It still provides monitoring histograms for the old ETL-1 disk geometry, distinguishing between the two geometries via MTDTopologyMode.
PR validation:
The new code has been tested in CMSSW_11_2_0_pre7. It needs the full 2-Disks geometry implemented in #31765 to be tested on 2-Disks scenarios, and #31654 to produce meaningful results for the new geometry.
The size of the new histograms is:
962.49 KiB MTD/ETL
238.40 KiB MTD/BTL
18.05 KiB MTD/GlobalReco
with respect to previous size:
481.31 KiB MTD/ETL
238.40 KiB MTD/BTL
12.77 KiB MTD/GlobalReco