Clean up a few dead assignments from CalibCalorimetry/HcalAlgos and RecoMuon/TrackingTools

[perrotta]

PR description:

Following some finding of the static analyzer, a few dead assignments are removed from the mentioned packages
I also took the opportunitiy to get rid of one extra sqrt computation in MuonErrorMatrix::Term(const AlgebraicSymMatrix55 &curv, int i, int j)

PR validation:

It builds correctly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31781/19040

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos
RecoMuon/TrackingTools

@perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@bellan, @abdoulline, @abbiendi, @Fedespring, @echapon, @calderona, @cericeci, @HuguesBrun, @jhgoh, @tocheng, @mmusich, @trocino, @mariadalfonso, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-13-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9936/console Started: 2020/10/14 09:43

[cmsbuild]

+1
Tested at: ab1d3e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7361ac/9936/summary.html
CMSSW: CMSSW_11_2_X_2020-10-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7361ac/9936/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543729
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Trivial clean up
• Jenkins tests pass

[yuanchao]

For 'CalibCalorimetry/HcalAlgos/src/HcalLogicalMapGenerator.cc' the modification is just commended out the dead assignment. Would it be better just remove the whole line? or 'mytype = 3' is still meaningful somewhere?

[perrotta]

For 'CalibCalorimetry/HcalAlgos/src/HcalLogicalMapGenerator.cc' the modification is just commended out the dead assignment. Would it be better just remove the whole line? or 'mytype = 3' is still meaningful somewhere?

It was done on purpose, since I don't know if such an assignment was left as such with the intention of possibly reusing it in further developments. Of course, if the responsible of the code agrees that there is no reason to let such a "promemoria" in the code I will remove that line as a whole.

[abdoulline]

Not remembering all the details of the HcalLogicalMapGenerator (history), I'd suggest to keep the commented line.

…

On Fri, 16 Oct 2020, perrotta wrote: For 'CalibCalorimetry/HcalAlgos/src/HcalLogicalMapGenerator.cc' the modification is just commended out the dead assignment. Would it be better just remove the whole line? or 'mytype = 3' is still meaningful somewhere? It was done on purpose, since I don't know if such an assignment was left as such with the intention of possibly reusing it in further developments. Of course, if the responsible of the code agrees that there is no reason to let such a "promemoria" in the code I will remove that line as a whole. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, orunsubscribe.[ABGHJWQ3NX6HSGWN3PHBZDTSLAESNA5CNFSM4SQHILYKYY3PNVWWK3TUL52HS4DFVREXG43VMVB W63LNMVXHJKTDN5WW2ZLOORPWSZGOFJIJXVY.gif]

[silviodonato]

Kind reminder @cms-sw/alca-l2

[silviodonato]

urgent
can we merge this PR in pre8?
@cms-sw/alca-l2

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1