New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hardcode the global tag in the unit test #31806
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31806/19102
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: CondCore/ESSources @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+alca |
@ggovi, @silviodonato, @cvuosalo we need this to fully test #31729. If we can get it merged asap would be extremely useful :) |
It's less than 10 lines, trivial and noncontroversial, so it should be easy to review. Still needs db approval. (If it is more convenient, I don't mind if you just include these changes in your PR and we close this one. I'm happy either way) |
merge |
@silviodonato Thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
The unit test has a problem because it hardcodes the global tag and this can cause failures when records in the global tag are removed from CMSSW. Hardcoding the tag instead is less brittle and should work just as well in this test.
See #28010 (review)
PR validation:
Problem unit test passes with this change. This change does not affect anything other than the unit test.