Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode the global tag in the unit test #31806

Merged
merged 1 commit into from Oct 16, 2020

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Oct 15, 2020

PR description:

The unit test has a problem because it hardcodes the global tag and this can cause failures when records in the global tag are removed from CMSSW. Hardcoding the tag instead is less brittle and should work just as well in this test.

See #28010 (review)

PR validation:

Problem unit test passes with this change. This change does not affect anything other than the unit test.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31806/19102

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

CondCore/ESSources

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Oct 15, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 66d6251
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21f3ee/9995/summary.html
CMSSW: CMSSW_11_2_X_2020-10-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21f3ee/9995/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor

+alca

@vargasa
Copy link
Contributor

vargasa commented Oct 16, 2020

@ggovi, @silviodonato, @cvuosalo we need this to fully test #31729. If we can get it merged asap would be extremely useful :)

@wddgit
Copy link
Contributor Author

wddgit commented Oct 16, 2020

It's less than 10 lines, trivial and noncontroversial, so it should be easy to review. Still needs db approval. (If it is more convenient, I don't mind if you just include these changes in your PR and we close this one. I'm happy either way)

@silviodonato
Copy link
Contributor

merge
@cms-sw/db-l2

@cmsbuild cmsbuild merged commit 7a24161 into cms-sw:master Oct 16, 2020
@vargasa
Copy link
Contributor

vargasa commented Oct 16, 2020

@silviodonato Thanks!

@ggovi
Copy link
Contributor

ggovi commented Oct 16, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@wddgit wddgit deleted the dontHarcodeGlobalTag branch May 3, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants