Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF standard sequences cleanup #31809

Merged
merged 2 commits into from Oct 16, 2020

Conversation

namapane
Copy link
Contributor

PR description:

  • Get rid of MagneticField_38T_PostLS1_cff, which has been deprecated ages ago;
  • fix ConfigBuilder.py to use the standard MF sequence. As of now, and for data only, it was forcing loading of MagneticField_AutoFromDBCurrent_cff which anyhow points to the standard sequence.

Note that the latter fix removes a meaningless warning message from ConfigBuilder.py as well.

These changes have been recently discussed in #31651 (comment)

Note: a significant number of instances of MagneticField_AutoFromDBCurrent_cff is still present in cfg files all around. A good fraction is being handled in #31788; others will be a subject of future PRs, before we can finally remove that cff.

PR validation:

Changes are trivial; ie replacing obsolete sequences with others that load exactly the same field map.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31809/19107

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @namapane (Nicola Amapane) for master.

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
SimMuon/RPCDigitizer
Validation/HGCalValidation
Validation/MuonGEMHits
Validation/RecoJets
Validation/RecoMET
Validation/TrackerRecHits

@andrius-k, @kmaeshima, @ErnestaP, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @civanch, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @felicepantaleo, @schoef, @jshlee, @bsunanda, @pfs, @lgray, @threus, @seemasharmafnal, @jhgoh, @mmarionncern, @sethzenz, @apsallid, @makortel, @watson-ij, @dgulhan, @jdolen, @slomeo, @jdamgov, @vandreev11, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @nhanvtran, @gkasieczka, @deguio, @wmtford, @mtosi, @fabiocos, @clelange, @arossi83, @Martin-Grunewald, @ahinzmann, @hatakeyamak, @lecriste, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: fab0961
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9503f8/9998/summary.html
CMSSW: CMSSW_11_2_X_2020-10-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9503f8/9998/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@civanch
Copy link
Contributor

civanch commented Oct 16, 2020

+1

@jfernan2
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7f18adc into cms-sw:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants