Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GEM offline DQM sequences #31818

Conversation

seungjin-yang
Copy link
Contributor

PR description:

  • Add a GEM offline DQM source sequence for cosmics scenario.
  • Move GEM offline DQM source and client sequences from POG to DPG.

@jshlee @watson-ij @szaleski

PR validation:

Tested with the workflow 11611.0 (2021, TenMu).

…moved source/client sequences from POG to PDG.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31818/19119

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @bellan, @threus, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f9a0cf3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4a12b/10011/summary.html
CMSSW: CMSSW_11_2_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4a12b/10011/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

@seungjin-yang I don't see plots added to wf11634.0 2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
which should be a similar one to the one you tested 11611.0 (I don't find its definition in runTheMatrix.py --show | grep 11611.0
sorry), I believe this is not expected

@seungjin-yang
Copy link
Contributor Author

seungjin-yang commented Oct 16, 2020

@jfernan2 Era should be the same or later than Run3 and so we need -w upgrade. Could you try the following one?

runTheMatrix.py -w upgrade -l 11611.0

@jfernan2
Copy link
Contributor

OK @seungjin-yang I understand what is going on: since your plots were already in, you just corrected the DQMOffline config file to run them (from POG to DPG, as it should be), the system does not see any change (plots remain in the same folder GEM/* )

Your backport PR DOES see the plots:
#31819 (comment)

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b57b75c into cms-sw:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants